<html>
<head><meta charset="utf-8"><title>Wrapping up v0.2 · t-cargo/PubGrub · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/index.html">t-cargo/PubGrub</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html">Wrapping up v0.2</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="215496058"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/215496058" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#215496058">(Nov 03 2020 at 18:54)</a>:</h4>
<p>We've done a lot of things since we joined forces (so much I won't list them now ^^). I'd really like if we could focus this couple of weeks on cleaning things up and releasing a v0.2. For that, in my opinion we'd need to:</p>
<ul>
<li>complete refactor <a href="https://github.com/mpizenberg/pubgrub-rs/issues/46">pubgrub#46</a>, <a href="https://github.com/mpizenberg/pubgrub-rs/issues/48">pubgrub#48</a> <a href="https://github.com/mpizenberg/pubgrub-rs/issues/53">pubgrub#53</a> (Alex PRs)</li>
<li>complete <a href="https://github.com/mpizenberg/pubgrub-rs/issues/50">pubgrub#50</a> on make_decision api change (waiting on Alex validation)</li>
<li>complete <a href="https://github.com/mpizenberg/pubgrub-rs/issues/55">pubgrub#55</a> that raise errors on forbidden dependencies (waiting on Alex validation)</li>
<li>finish <a href="https://github.com/mpizenberg/pubgrub-rs/issues/58">pubgrub#58</a> which simplifies the memory type (I need to check latest changes from Jacob and restore the behavior that "ask permission")</li>
<li>complete <a href="https://github.com/mpizenberg/pubgrub-rs/issues/60">pubgrub#60</a> which simplifies conflict resolution (normally a no-brainer, but just need a quick check on my part)</li>
<li>complete the guide <a href="https://github.com/mpizenberg/pubgrub-rs/issues/45">pubgrub#45</a>.</li>
<li>general polishing</li>
</ul>
<p><span class="user-mention" data-user-id="120179">@Eh2406</span>  you seem to be the one most ahead of us regarding work left, would you mind helping completing the guide?</p>



<a name="215497512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/215497512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#215497512">(Nov 03 2020 at 19:05)</a>:</h4>
<p>I will try to focus on what needs to be done instead of perf. But I do love perf work and long form writing is not my strong suit. So we will see what happens <span aria-label="stuck out tongue" class="emoji emoji-1f61b" role="img" title="stuck out tongue">:stuck_out_tongue:</span> <br>
<span class="user-mention" data-user-id="348419">@Matthieu Pizenberg</span>  Any guidance on on how I can help with the guide?</p>



<a name="215499538"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/215499538" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#215499538">(Nov 03 2020 at 19:25)</a>:</h4>
<p>Ahah, regarding the guide there are 3 subsections untouched yet in the section about using pubgrub. There is also the section about describing how to do performance optimization since you like perf work ^^.</p>



<a name="215500218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/215500218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#215500218">(Nov 03 2020 at 19:32)</a>:</h4>
<p>Otherwise, before continuing perf work, it would be better to widen our synthetic dataset of registries with real ones. I'll handle the elm one, but if you could find another one that could be handled already as discussed in the corresponding issue (cannot link now, on mobile) that would be great</p>



<a name="215771772"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/215771772" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#215771772">(Nov 05 2020 at 20:47)</a>:</h4>
<p>I did some work on the guide, I could use some feedback to make sure it is helpful and my plans are in the correct direction.</p>



<a name="215772883"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/215772883" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#215772883">(Nov 05 2020 at 20:57)</a>:</h4>
<p>I also started trying to build a benchmark from <a href="https://github.com/rust-lang/crates.io-index">https://github.com/rust-lang/crates.io-index</a><br>
Taking only versions that are supported by our <code>SemanticVersion</code>.<br>
Converting dependency requirements to <code>Range</code> by finding the min and max that match the original requirement and doing <code>Range::between(min, max.bump())</code>.<br>
Optional dependencies are assumed to be required, unless it will make my script have an infinite loop.<br>
So this is not realistic as it is "one-per-name" not "one-per-major" and it does not handle optional correctly, but it is based on a true source. And it is 5MB.</p>



<a name="215889411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/215889411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#215889411">(Nov 06 2020 at 19:01)</a>:</h4>
<p>Better handling of the circular dependencies, now allow it to just say all optional dependencies are assumed to be required.<br>
Only processing versions that match some requirement brings the file down to 1.5MB.</p>



<a name="215930545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/215930545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#215930545">(Nov 07 2020 at 04:04)</a>:</h4>
<p>Handling optional dependencies correctly. Using the plan from <a href="https://github.com/pubgrub-rs/advanced_dependency_providers/issues/1">https://github.com/pubgrub-rs/advanced_dependency_providers/issues/1</a>, brings it back up to 7MB.</p>



<a name="216154482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216154482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216154482">(Nov 09 2020 at 23:07)</a>:</h4>
<p>So I added a hack for "one-per-major", by skipping dependencies like "&gt;=0.3, &lt;0.5" which does not happen in the crates that happen to be selected.<br>
Now trying to figure out why it thinks that <code>serde="&gt;=1.0.117"</code> does not have a solution when that is the version that cargo selects. Clearly a bug somewhere. And the SAT solver does not think it is in PubGrub. So it must be in my mess.</p>



<a name="216168227"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216168227" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216168227">(Nov 10 2020 at 02:56)</a>:</h4>
<p>Got it working! So it is now a fairly small "happy path" benchmark. It may be more interesting with minimum versions, but that is an experiment for another time. What parts of the file are relevant to the benchmark will change with <a href="https://github.com/mpizenberg/pubgrub-rs/issues/50">pubgrub#50</a>, so I will wait on that to make a PR.<br>
Meanwhile the code for generating the benchmark, while a hacky mess, may be useful to build other benchmarks and start exploring Cargos use cases.</p>



<a name="216321318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216321318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216321318">(Nov 11 2020 at 09:08)</a>:</h4>
<blockquote>
<p>I did some work on the guide, I could use some feedback to make sure it is helpful and my plans are in the correct direction.</p>
</blockquote>
<p>Thanks! I finally get some time until next week :)</p>



<a name="216321548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216321548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216321548">(Nov 11 2020 at 09:10)</a>:</h4>
<blockquote>
<p>Meanwhile the code for generating the benchmark, while a hacky mess, may be useful to build other benchmarks and start exploring Cargos use cases</p>
</blockquote>
<p>great!</p>



<a name="216327143"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216327143" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216327143">(Nov 11 2020 at 10:12)</a>:</h4>
<p><span class="user-mention" data-user-id="120179">@Eh2406</span> I'm not getting the pigeonhole analogy, what is meant to be compared with the pigeon / the hole?</p>



<a name="216370456"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216370456" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216370456">(Nov 11 2020 at 16:52)</a>:</h4>
<p>Also I'm not understanding the sentence</p>
<blockquote>
<p>If pubgrub finds a solution then adding statements that match it does not lead to a contradiction</p>
</blockquote>



<a name="216370748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216370748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216370748">(Nov 11 2020 at 16:54)</a>:</h4>
<p>Thanks for the explanation on the strategy and the sat solver! I've reviewed and modified it directly in the guide branch. Let me know if you do not like some changes I made.</p>



<a name="216394048"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216394048" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216394048">(Nov 11 2020 at 20:19)</a>:</h4>
<p><span class="user-mention" data-user-id="348419">@Matthieu Pizenberg</span>  I like all the changes you made! Thank you!</p>



<a name="216395670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216395670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216395670">(Nov 11 2020 at 20:35)</a>:</h4>
<blockquote>
<p>pigeonhole analogy</p>
</blockquote>
<p>The thought was that the dependencies are the "pigeons" and the packages that can be depended on are the "holes".<br>
Let's say we are making dependencies for a version the package "D" and we can have 5 dependencies . We will end up depending on all the packages available as there are only 3 (A..=B). Pick 5 from 3. </p>
<p>anyway with your edits, it is clear enough without the reference.</p>



<a name="216396468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216396468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216396468">(Nov 11 2020 at 20:43)</a>:</h4>
<blockquote>
<p>If pubgrub finds a solution then adding statements that match it does not lead to a contradiction</p>
</blockquote>
<p>I was trying (unsuccessfully) to describe <a href="https://github.com/pubgrub-rs/pubgrub/blob/dev/tests/sat_dependency_provider.rs#L126-L145">this assertion</a>. If pubgrub thinks there is a solution, then setting <code>b_p,v</code> to true if that version is selected and to false if it is not selected should make the SAT solver happy.</p>



<a name="216396903"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216396903" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216396903">(Nov 11 2020 at 20:46)</a>:</h4>
<p>ooh I see, isn't that an implementation detail of saying "check that this solution is valid"?</p>



<a name="216397360"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216397360" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216397360">(Nov 11 2020 at 20:51)</a>:</h4>
<p>I interpreted it in my modification as a "if and only if". But in reality, we don't run the SAT solver from scratch for a registry. We initialize it with pubgrub solution and check that the solution is correct. Only if pubgrub does not find a solution, we run the SAT and verify that no solution is found either.</p>
<p>I'll modify that "if and only if" in the guide</p>



<a name="216397644"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216397644" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216397644">(Nov 11 2020 at 20:53)</a>:</h4>
<blockquote>
<p>ooh I see, isn't that an implementation detail of saying "check that this solution is valid"?</p>
</blockquote>
<p>I mean, instead of explaining in details that we add assumptions, and verify that the sat solver still pass, I think we can just state that we use the SAT solver to check a solution.</p>



<a name="216397771"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216397771" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216397771">(Nov 11 2020 at 20:54)</a>:</h4>
<p>Sounds good.</p>



<a name="216418982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216418982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216418982">(Nov 12 2020 at 01:50)</a>:</h4>
<p>If you want me to try a draft at some other sections, I could use some feedback on <a href="https://github.com/pubgrub-rs/pubgrub/pull/45#issuecomment-721372342">https://github.com/pubgrub-rs/pubgrub/pull/45#issuecomment-721372342</a></p>



<a name="216488858"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216488858" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216488858">(Nov 12 2020 at 16:06)</a>:</h4>
<p>I went ahead and merged the three clippy-related issues initiated by <span class="user-mention" data-user-id="340766">@Alex Tokarev</span>. There was very few things left to check. I made small changes explained in the respective PRs before merging them.</p>



<a name="216490283"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216490283" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216490283">(Nov 12 2020 at 16:14)</a>:</h4>
<p><span class="user-mention" data-user-id="120179">@Eh2406</span> now that clippy-related PRs are merged, could you rebase your PRs 50 to 60 on dev so that clippy also runs on those. I'll assume that issue 50 introducing <code>make_decision</code> will be merged and finish the guide accordingly.</p>



<a name="216490774"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216490774" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216490774">(Nov 12 2020 at 16:18)</a>:</h4>
<p><span class="user-mention" data-user-id="340766">@Alex Tokarev</span> when you have some time, the priority now is checking that PRs <a href="https://github.com/mpizenberg/pubgrub-rs/issues/50">pubgrub#50</a>, <a href="https://github.com/mpizenberg/pubgrub-rs/issues/55">pubgrub#55</a> and <a href="https://github.com/mpizenberg/pubgrub-rs/issues/58">pubgrub#58</a> are ok for you.</p>



<a name="216492423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216492423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216492423">(Nov 12 2020 at 16:30)</a>:</h4>
<p>Hi <span class="user-mention" data-user-id="348419">@Matthieu Pizenberg</span>. I was on-call support with a few sleepless nights in a row. And you don't have less work during day time either, quite the opposite. I'm going insane <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span><br>
Fortunately it's about to end, so I will go through the PRs this weekend.</p>
<p>Sorry for not participating more lately, I'm disappointed myself that I'm being a bottleneck here.</p>



<a name="216492922"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216492922" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216492922">(Nov 12 2020 at 16:33)</a>:</h4>
<p>Don't worry <span class="user-mention" data-user-id="340766">@Alex Tokarev</span> I assumed you'd be overbooked and removed a bit of your work load ^^. Take care and recover some sleep first! Then when you feel better you can have a look at those PRs</p>



<a name="216508531"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216508531" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216508531">(Nov 12 2020 at 18:29)</a>:</h4>
<p><span class="user-mention" data-user-id="340766">@Alex Tokarev</span> Yes, self care has to be the priority. Get some sleep.<br>
<span class="user-mention" data-user-id="348419">@Matthieu Pizenberg</span> All your changes look wonderful to me. Did you like the "ask permission" version of <a href="https://github.com/mpizenberg/pubgrub-rs/issues/58">pubgrub#58</a>?<br>
I will work on rebasing when I get a minute  to look at it.</p>



<a name="216513107"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216513107" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216513107">(Nov 12 2020 at 19:04)</a>:</h4>
<p>I haven't checked yet what you did there. I'll look at it tomorrow I think</p>



<a name="216540031"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216540031" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216540031">(Nov 12 2020 at 22:41)</a>:</h4>
<p>Rebased.</p>



<a name="216686760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216686760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216686760">(Nov 13 2020 at 23:10)</a>:</h4>
<p>finished my detailed review of 50, tomorrow I'll redo a detailed review of 58</p>



<a name="216730718"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216730718" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216730718">(Nov 14 2020 at 14:00)</a>:</h4>
<p>PRs 50, 55, 58, 60 and 61 are ready to be merged when we have Alex green light. Then I'll probably do a cleanup and preparation PR for v0.2.</p>
<p>As said in the "guide" PR, I think it will make more sense to move the guide out of the code repo, so I'll do that just before PR for v0.2</p>



<a name="216730798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216730798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216730798">(Nov 14 2020 at 14:03)</a>:</h4>
<p>Meanwhile, I'll work on code to read config files of elm projects in order to prepare the registry index of all elm packages for benchmark purposes. That will also be useful for the elm dependency provider.</p>



<a name="216734592"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216734592" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216734592">(Nov 14 2020 at 15:32)</a>:</h4>
<p>Hi everyone, I'm catching up to all the awesome work you've done so far <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="216737148"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216737148" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216737148">(Nov 14 2020 at 16:26)</a>:</h4>
<blockquote>
<p>Meanwhile, I'll work on code to read config files of elm projects in order to prepare the registry index of all elm packages for benchmark purposes. That will also be useful for the elm dependency provider.</p>
</blockquote>
<p>What I was thinking when working on my "serde" benchmark is that the in tree benchmark code is a <code>*_str_SemanticVersion.ron</code> file. The code to parse the index / config files and convert to the ron file can live out of tree. What did you have in mind?</p>



<a name="216739591"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216739591" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216739591">(Nov 14 2020 at 17:16)</a>:</h4>
<blockquote>
<p>What did you have in mind?</p>
</blockquote>
<p>Nothing special, I'm just doing some ad-hoc executable to fetch and read all the <code>elm.json</code> configs of all elm packages, and putting them all together in an <code>OfflineDependencyProvider</code> to serialize this into a ron file.</p>



<a name="216739669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216739669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216739669">(Nov 14 2020 at 17:19)</a>:</h4>
<p>Sounds like we are on the same page.</p>



<a name="216753116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/216753116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#216753116">(Nov 14 2020 at 22:13)</a>:</h4>
<p>I've caught up with the changes to my merged PRs, all good <span aria-label="rocket" class="emoji emoji-1f680" role="img" title="rocket">:rocket:</span></p>
<p>I've left some comments on <a href="https://github.com/mpizenberg/pubgrub-rs/issues/50">pubgrub#50</a> which I'd like to discuss, and did naming changes to <a href="https://github.com/mpizenberg/pubgrub-rs/issues/55">pubgrub#55</a> which is ready to merge if you agree with them.</p>
<p>Will continue tomorrow <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span> Thank you again for your work and for being so patient <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span></p>



<a name="217120478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217120478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217120478">(Nov 18 2020 at 11:02)</a>:</h4>
<p>Post for /r/rust when publishing v0.2:</p>
<hr>
<h1>Announcing pubgrub v0.2: a flexible version solver</h1>
<p>PubGrub is a version solving algorithm based on conflict driven no-good learning,<br>
created by Natalie Weizenbaum for the package manager of the Dart programming language.<br>
Its goal is to compute a set of package versions that satisfies all dependencies of a project,<br>
and it aims at being faster than the alternatives,<br>
while giving better explanations when no solution is possible.</p>
<p>This crate is an implementation from scratch of the PubGrub algorithm in Rust.<br>
It is generic over the package and version types to provide maximum flexibility.<br>
A guide is also provided to walk you through its high-level features and internal details.<br>
Beware that it's still a WIP so API changes will continue to occur<br>
but we are now ready for community feedback.</p>



<a name="217137688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217137688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217137688">(Nov 18 2020 at 14:02)</a>:</h4>
<p>That sounds like a wonderful announcement.</p>



<a name="217143957"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217143957" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217143957">(Nov 18 2020 at 14:50)</a>:</h4>
<blockquote>
<p>no-good learning</p>
</blockquote>
<p>Does it mean it's bad? /s</p>



<a name="217144807"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217144807" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217144807">(Nov 18 2020 at 14:56)</a>:</h4>
<blockquote>
<p>Does it mean it's bad? /s</p>
</blockquote>
<p>good spot actually it's "nogood" without the "-"</p>



<a name="217158235"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217158235" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217158235">(Nov 18 2020 at 16:19)</a>:</h4>
<p>I was just making a joke but I guess <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="217158361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217158361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217158361">(Nov 18 2020 at 16:20)</a>:</h4>
<p>Do we want to note in the post that the crate is under active development and API is subject to change?</p>



<a name="217158860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217158860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217158860">(Nov 18 2020 at 16:23)</a>:</h4>
<p>I prefer to lower people expectation so only the most motivated persons start interacting ^^</p>



<a name="217164321"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217164321" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217164321">(Nov 18 2020 at 16:58)</a>:</h4>
<p>Ah right, actually I wanted to note that as well and didn't notice you already did so in the last sentence.</p>



<a name="217177358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217177358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217177358">(Nov 18 2020 at 18:33)</a>:</h4>
<p>It looks like we've covered everything important, <span class="user-mention" data-user-id="120179">@Eh2406</span> how should I add you to the <code>authors</code> field of cargo toml? (name and email)</p>



<a name="217177869"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217177869" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217177869">(Nov 18 2020 at 18:37)</a>:</h4>
<p>Did we generate a changelog already?</p>



<a name="217177983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217177983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217177983">(Nov 18 2020 at 18:38)</a>:</h4>
<p>I wrote it manually yeah, you can have a look at it in the pr</p>



<a name="217178151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217178151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217178151">(Nov 18 2020 at 18:40)</a>:</h4>
<p>Looks like I used "Jacob Finkelman &lt;<a href="mailto:Eh2406@wayne.edu">Eh2406@wayne.edu</a>&gt;" in previous projects.</p>



<a name="217178362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217178362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217178362">(Nov 18 2020 at 18:41)</a>:</h4>
<p><span class="user-mention" data-user-id="340766">@Alex Tokarev</span> what is the conventionnal tag for a modification of cargo toml?</p>



<a name="217179074"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217179074" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217179074">(Nov 18 2020 at 18:47)</a>:</h4>
<blockquote>
<p>Did we generate a changelog already?</p>
</blockquote>
<p>I need to change the release date</p>



<a name="217180495"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217180495" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217180495">(Nov 18 2020 at 18:58)</a>:</h4>
<p>Good question. Looking at this list <a href="https://github.com/angular/angular/blob/master/CONTRIBUTING.md#type">https://github.com/angular/angular/blob/master/CONTRIBUTING.md#type</a> where we stole our tags from, nothing really fits for adding an author. As for changes to Cargo.toml in general, <code>build</code> seems appropriate.</p>



<a name="217181002"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217181002" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217181002">(Nov 18 2020 at 19:01)</a>:</h4>
<p>Found a good way to look at changelog: <a href="https://github.com/pubgrub-rs/pubgrub/pull/63/files?short_path=06572a9#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed">https://github.com/pubgrub-rs/pubgrub/pull/63/files?short_path=06572a9#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed</a></p>



<a name="217181274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217181274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217181274">(Nov 18 2020 at 19:03)</a>:</h4>
<blockquote>
<p>Changes affecting the public API</p>
</blockquote>
<p>Or we can say "breaking changes"</p>



<a name="217181348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217181348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217181348">(Nov 18 2020 at 19:04)</a>:</h4>
<blockquote>
<p>Using SPDX license identifiers instead of MPL-2.0 classic file headers.</p>
</blockquote>
<p>That's a part of internal changes, not public</p>



<a name="217181533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217181533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217181533">(Nov 18 2020 at 19:05)</a>:</h4>
<blockquote>
<p>The Solver trait was replaced by a DependencyProvider trait which now must implement a choose_package_version method instead of list_available_versions. So it now has the ability to choose a package in addition to a version. </p>
</blockquote>
<p>There was no option to choose a version before.</p>



<a name="217181672"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217181672" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217181672">(Nov 18 2020 at 19:06)</a>:</h4>
<p>you could choose what order the versions were tried in.</p>



<a name="217181965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217181965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217181965">(Nov 18 2020 at 19:08)</a>:</h4>
<p>Well.. true. I retract my comment <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="217182063"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217182063" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217182063">(Nov 18 2020 at 19:09)</a>:</h4>
<blockquote>
<p>New "serde" feature that serialize and deserialize few types in the API.</p>
</blockquote>
<p>We used it for benchmarking only, does it have any practical public uses?</p>



<a name="217182171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217182171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217182171">(Nov 18 2020 at 19:10)</a>:</h4>
<p>If someone else wants to make a benchmark? Or store test cases?</p>



<a name="217182367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217182367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217182367">(Nov 18 2020 at 19:12)</a>:</h4>
<p>Isn't that only for library developers? <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="217182511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217182511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217182511">(Nov 18 2020 at 19:12)</a>:</h4>
<p>For users they would store their own test cases in whatever format they use to supply dependencies into DependencyProvider</p>



<a name="217182559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217182559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217182559">(Nov 18 2020 at 19:13)</a>:</h4>
<p>Ya, probably.</p>



<a name="217182763"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217182763" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217182763">(Nov 18 2020 at 19:14)</a>:</h4>
<blockquote>
<p>New variants for error::PubGrubError which are DependencyOnTheEmptySet, SelfDependency, ErrorChoosingPackageVersion and ErrorShouldCancel</p>
</blockquote>
<p>When I read this sentence I realized <code>ErrorShouldCancel</code> sounds somewhat robotic <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span> Can we do a quick <code>ErrorInShouldCancel</code> change before publishing?</p>



<a name="217183357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217183357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217183357">(Nov 18 2020 at 19:18)</a>:</h4>
<p>I just realized a lot of these comments are better suited as Github "request changes" ones, going to submit trivial stuff there.</p>



<a name="217184825"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217184825" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217184825">(Nov 18 2020 at 19:29)</a>:</h4>
<blockquote>
<p>Or we can say "breaking changes"</p>
</blockquote>
<p>This is different, changes can affect the public API without being breaking changes. They are only breaking of there is something in the <code>changed</code> and <code>removed</code> sections</p>



<a name="217185013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217185013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217185013">(Nov 18 2020 at 19:31)</a>:</h4>
<p>I was not comfortable putting all internal changes in one single category so I preferred duplicate the sections into user-facing and not user-facing</p>



<a name="217185236"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217185236" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217185236">(Nov 18 2020 at 19:32)</a>:</h4>
<p>Regarding SPDX, it is not breaking anything but that changes does touch public-facing code.</p>



<a name="217185342"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217185342" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217185342">(Nov 18 2020 at 19:33)</a>:</h4>
<blockquote>
<p>We used it for benchmarking only, does it have any practical public uses?</p>
</blockquote>
<p>Yes it does, I need it in the elm dependency provider</p>



<a name="217185605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217185605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217185605">(Nov 18 2020 at 19:35)</a>:</h4>
<blockquote>
<p>Regarding SPDX, it is not breaking anything but that changes does touch public-facing code.</p>
</blockquote>
<p>The license is the same, why does public care about what format we use to convey it <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="217185702"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217185702" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217185702">(Nov 18 2020 at 19:36)</a>:</h4>
<blockquote>
<p>Yes it does, I need it in the elm dependency provider</p>
</blockquote>
<p>Interesting! Could you link to it please?</p>



<a name="217185735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217185735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217185735">(Nov 18 2020 at 19:36)</a>:</h4>
<p>I don't know ^^. I just notice it's a change and it's public facing. If people use it for their script and such, don't know ^^</p>



<a name="217185820"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217185820" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217185820">(Nov 18 2020 at 19:37)</a>:</h4>
<p>Maybe a bit far-fetched, I'm fine putting this in the internal section too</p>



<a name="217186056"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217186056" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217186056">(Nov 18 2020 at 19:39)</a>:</h4>
<p>a new serde feature that allows serializing some types from the library, mostly useful for making simple reproducible bug reports for this library.</p>



<a name="217186349"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217186349" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217186349">(Nov 18 2020 at 19:41)</a>:</h4>
<blockquote>
<p>Interesting! Could you link to it please?</p>
</blockquote>
<p>Can't link since there is no repo yet but basically I have this for example:</p>
<div class="codehilite" data-code-language="Rust"><pre><span></span><code><span class="k">pub</span><span class="w"> </span><span class="k">struct</span> <span class="nc">Constraint</span><span class="p">(</span><span class="k">pub</span><span class="w"> </span><span class="n">Range</span><span class="o">&lt;</span><span class="n">SemVer</span><span class="o">&gt;</span><span class="p">);</span><span class="w"></span>

<span class="k">impl</span><span class="w"> </span><span class="n">Serialize</span><span class="w"> </span><span class="k">for</span><span class="w"> </span><span class="n">Constraint</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="k">fn</span> <span class="nf">serialize</span><span class="o">&lt;</span><span class="n">S</span><span class="o">&gt;</span><span class="p">(</span><span class="o">&amp;</span><span class="bp">self</span><span class="p">,</span><span class="w"> </span><span class="n">serializer</span>: <span class="nc">S</span><span class="p">)</span><span class="w"> </span>-&gt; <span class="nb">Result</span><span class="o">&lt;</span><span class="n">S</span>::<span class="nb">Ok</span><span class="p">,</span><span class="w"> </span><span class="n">S</span>::<span class="n">Error</span><span class="o">&gt;</span><span class="w"></span>
<span class="w">    </span><span class="k">where</span><span class="w"></span>
<span class="w">        </span><span class="n">S</span>: <span class="nc">Serializer</span><span class="p">,</span><span class="w"></span>
<span class="w">    </span><span class="p">{</span><span class="w"></span>
<span class="w">        </span><span class="n">serializer</span><span class="p">.</span><span class="n">serialize_str</span><span class="p">(</span><span class="bp">self</span><span class="p">.</span><span class="mf">0.</span><span class="n">to_string</span><span class="p">().</span><span class="n">as_str</span><span class="p">())</span><span class="w"></span>
<span class="w">    </span><span class="p">}</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>

<span class="k">impl</span><span class="o">&lt;'</span><span class="na">de</span><span class="o">&gt;</span><span class="w"> </span><span class="n">Deserialize</span><span class="o">&lt;'</span><span class="na">de</span><span class="o">&gt;</span><span class="w"> </span><span class="k">for</span><span class="w"> </span><span class="n">Constraint</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="k">fn</span> <span class="nf">deserialize</span><span class="o">&lt;</span><span class="n">D</span><span class="o">&gt;</span><span class="p">(</span><span class="n">deserializer</span>: <span class="nc">D</span><span class="p">)</span><span class="w"> </span>-&gt; <span class="nb">Result</span><span class="o">&lt;</span><span class="bp">Self</span><span class="p">,</span><span class="w"> </span><span class="n">D</span>::<span class="n">Error</span><span class="o">&gt;</span><span class="w"></span>
<span class="w">    </span><span class="k">where</span><span class="w"></span>
<span class="w">        </span><span class="n">D</span>: <span class="nc">Deserializer</span><span class="o">&lt;'</span><span class="na">de</span><span class="o">&gt;</span><span class="p">,</span><span class="w"></span>
<span class="w">    </span><span class="p">{</span><span class="w"></span>
<span class="w">        </span><span class="kd">let</span><span class="w"> </span><span class="n">s</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="nb">String</span>::<span class="n">deserialize</span><span class="p">(</span><span class="n">deserializer</span><span class="p">)</span><span class="o">?</span><span class="p">;</span><span class="w"></span>
<span class="w">        </span><span class="n">FromStr</span>::<span class="n">from_str</span><span class="p">(</span><span class="o">&amp;</span><span class="n">s</span><span class="p">).</span><span class="n">map_err</span><span class="p">(</span><span class="n">serde</span>::<span class="n">de</span>::<span class="n">Error</span>::<span class="n">custom</span><span class="p">)</span><span class="w"></span>
<span class="w">    </span><span class="p">}</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="217186416"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217186416" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217186416">(Nov 18 2020 at 19:41)</a>:</h4>
<p>Bad example XD</p>



<a name="217186788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217186788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217186788">(Nov 18 2020 at 19:44)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120179">Eh2406</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217186056">said</a>:</p>
<blockquote>
<p>a new serde feature that allows serializing some types from the library, mostly useful for making simple reproducible bug reports for this library.</p>
</blockquote>
<p>Hm, sounds like a nice description! I'll submit it as a proposal to the changelog if you don't mind.</p>



<a name="217187355"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217187355" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217187355">(Nov 18 2020 at 19:49)</a>:</h4>
<blockquote>
<p>Interesting! Could you link to it please?</p>
</blockquote>
<p>So I've skimmed through the code and in fact I whished I had it but the code was based on the master branch when I started so there wasn't the feature and I was basically forced to copy-paste the whole SemanticVersion type into a file of my own. And I whished I didn't have to ^^</p>



<a name="217188000"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217188000" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217188000">(Nov 18 2020 at 19:54)</a>:</h4>
<p>Makes sense!</p>



<a name="217188511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217188511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217188511">(Nov 18 2020 at 19:58)</a>:</h4>
<blockquote>
<p>When I read this sentence I realized ErrorShouldCancel sounds somewhat robotic <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span> Can we do a quick ErrorInShouldCancel change before publishing?</p>
</blockquote>
<p><span class="user-mention" data-user-id="340766">@Alex Tokarev</span> fire it :)</p>



<a name="217188644"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217188644" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217188644">(Nov 18 2020 at 19:59)</a>:</h4>
<p>Going to! How did you mark a message with a red background?</p>



<a name="217188758"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217188758" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217188758">(Nov 18 2020 at 20:00)</a>:</h4>
<p>put your name in it, you are fire man</p>



<a name="217190870"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217190870" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217190870">(Nov 18 2020 at 20:17)</a>:</h4>
<p><span class="user-mention" data-user-id="340766">@Alex Tokarev</span> <br>
Woah</p>



<a name="217190910"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217190910" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217190910">(Nov 18 2020 at 20:17)</a>:</h4>
<p><span class="user-mention" data-user-id="348419">@Matthieu Pizenberg</span> <br>
Now your turn <span aria-label="fire" class="emoji emoji-1f525" role="img" title="fire">:fire:</span></p>



<a name="217190947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217190947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217190947">(Nov 18 2020 at 20:18)</a>:</h4>
<p>ahah</p>



<a name="217190978"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217190978" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217190978">(Nov 18 2020 at 20:18)</a>:</h4>
<p><span class="user-mention" data-user-id="120179">@Eh2406</span> <span aria-label="fire" class="emoji emoji-1f525" role="img" title="fire">:fire:</span></p>



<a name="217191260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217191260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217191260">(Nov 18 2020 at 20:20)</a>:</h4>
<p>Btw, I've <span aria-label="fire" class="emoji emoji-1f525" role="img" title="fire">:fire:</span>d the PR and submitted some change proposals here <a href="https://github.com/pubgrub-rs/pubgrub/pull/63">https://github.com/pubgrub-rs/pubgrub/pull/63</a>. Might add some more</p>



<a name="217191534"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217191534" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217191534">(Nov 18 2020 at 20:22)</a>:</h4>
<p>Epic fail on my attempt at commit your review ahahahah</p>



<a name="217191610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217191610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217191610">(Nov 18 2020 at 20:23)</a>:</h4>
<p>2nd attempt</p>



<a name="217192177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217192177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217192177">(Nov 18 2020 at 20:27)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217191534">said</a>:</p>
<blockquote>
<p>Epic fail on my attempt at commit your review ahahahah</p>
</blockquote>
<p>Why? I think you can just do it through Github with 1 button click</p>



<a name="217192273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217192273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217192273">(Nov 18 2020 at 20:28)</a>:</h4>
<p>Also "Add suggestion to batch" queues them for a single commit</p>



<a name="217192529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217192529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217192529">(Nov 18 2020 at 20:30)</a>:</h4>
<blockquote>
<p>Why?</p>
</blockquote>
<p><a href="https://github.com/pubgrub-rs/pubgrub/pull/63#pullrequestreview-533844186">https://github.com/pubgrub-rs/pubgrub/pull/63#pullrequestreview-533844186</a></p>



<a name="217192983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217192983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217192983">(Nov 18 2020 at 20:34)</a>:</h4>
<p>Didn't even notice!</p>



<a name="217193372"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217193372" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217193372">(Nov 18 2020 at 20:37)</a>:</h4>
<blockquote>
<p>![license](<a href="https://img.shields.io/crates/l/pubgrub.svg">https://img.shields.io/crates/l/pubgrub.svg</a>)</p>
</blockquote>
<p>Never heard of <a href="http://shields.io">shields.io</a>, is this where everyone hosts their badge icons?</p>



<a name="217193418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217193418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217193418">(Nov 18 2020 at 20:37)</a>:</h4>
<p>yes</p>



<a name="217193567"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217193567" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217193567">(Nov 18 2020 at 20:39)</a>:</h4>
<p>That conventional commit thingy is sometimes annoying me</p>



<a name="217193776"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217193776" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217193776">(Nov 18 2020 at 20:41)</a>:</h4>
<p>I guess you can ignore it if the commits are going to be squashed</p>



<a name="217193901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217193901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217193901">(Nov 18 2020 at 20:42)</a>:</h4>
<p>We can also configure it to produce a warning instead, so that the whole thing is marked as "Pipeline passed with warnings" instead.</p>



<a name="217194168"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217194168" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217194168">(Nov 18 2020 at 20:45)</a>:</h4>
<p>Alright, I've updated the release date now, everything ok?</p>



<a name="217194189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217194189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217194189">(Nov 18 2020 at 20:45)</a>:</h4>
<p>Cool, you can change badge colors directly in URL:<br>
<a href="https://img.shields.io/badge/guide-pubgrub-aa69b4?logo=read-the-docs">https://img.shields.io/badge/guide-pubgrub-aa69b4?logo=read-the-docs</a></p>



<a name="217194291"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217194291" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217194291">(Nov 18 2020 at 20:46)</a>:</h4>
<p>Yeah customization is almost infinite ^^</p>



<a name="217194304"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217194304" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217194304">(Nov 18 2020 at 20:46)</a>:</h4>
<p>there are other providers too</p>



<a name="217194879"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217194879" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217194879">(Nov 18 2020 at 20:51)</a>:</h4>
<p>Btw, the change in that color link what random one from 'ff' to 'aa' and I like it more. Going to sneak it in while you are not looking <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="217195019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217195019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217195019">(Nov 18 2020 at 20:52)</a>:</h4>
<p>Oh you can also just write <code>purple</code> instead<br>
<a href="https://img.shields.io/badge/guide-pubgrub-purple?logo=read-the-docs">https://img.shields.io/badge/guide-pubgrub-purple?logo=read-the-docs</a></p>



<a name="217195084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217195084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217195084">(Nov 18 2020 at 20:53)</a>:</h4>
<p>I liked the pink one :) used to live in the pink city: <a href="https://en.wikipedia.org/wiki/Toulouse">https://en.wikipedia.org/wiki/Toulouse</a></p>



<a name="217195200"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217195200" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217195200">(Nov 18 2020 at 20:54)</a>:</h4>
<p><a href="https://img.shields.io/badge/guide-pubgrub-pink?logo=read-the-docs">https://img.shields.io/badge/guide-pubgrub-pink?logo=read-the-docs</a></p>



<a name="217195284"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217195284" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217195284">(Nov 18 2020 at 20:55)</a>:</h4>
<p>I like that their "pink" version changes text color to black and it's easier to read</p>



<a name="217195357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217195357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217195357">(Nov 18 2020 at 20:55)</a>:</h4>
<p>Do you like that one? <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="217195387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217195387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217195387">(Nov 18 2020 at 20:56)</a>:</h4>
<p>Also, I realize I'm just goofing here <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="217195472"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217195472" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217195472">(Nov 18 2020 at 20:56)</a>:</h4>
<p>yep I'll change it</p>



<a name="217195713"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217195713" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217195713">(Nov 18 2020 at 20:58)</a>:</h4>
<p><span class="user-mention" data-user-id="340766">@Alex Tokarev</span> you still have your "request changes" active</p>



<a name="217195758"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217195758" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217195758">(Nov 18 2020 at 20:58)</a>:</h4>
<p>"change requested" I meant</p>



<a name="217196564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217196564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217196564">(Nov 18 2020 at 21:04)</a>:</h4>
<p>Hm, I don't know why, everything seems to be resolved.</p>



<a name="217196659"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217196659" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217196659">(Nov 18 2020 at 21:05)</a>:</h4>
<p>never used that feature I think we have to manually change it</p>



<a name="217196661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217196661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217196661">(Nov 18 2020 at 21:05)</a>:</h4>
<p>Well, I guess submitting an approve works.</p>



<a name="217196751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217196751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217196751">(Nov 18 2020 at 21:06)</a>:</h4>
<p>Alright count down 10s 9s 8s ...</p>



<a name="217196815"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217196815" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217196815">(Nov 18 2020 at 21:06)</a>:</h4>
<p>7 6 5</p>



<a name="217196865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217196865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217196865">(Nov 18 2020 at 21:07)</a>:</h4>
<p>4 3 2 1</p>



<a name="217196885"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217196885" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217196885">(Nov 18 2020 at 21:07)</a>:</h4>
<p>0</p>



<a name="217196897"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217196897" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217196897">(Nov 18 2020 at 21:07)</a>:</h4>
<p>what's the conventional commit ?</p>



<a name="217196901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217196901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217196901">(Nov 18 2020 at 21:07)</a>:</h4>
<p>lol</p>



<a name="217197057"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197057" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197057">(Nov 18 2020 at 21:09)</a>:</h4>
<p><a href="https://github.com/angular/angular/search?q=release&amp;type=commits">https://github.com/angular/angular/search?q=release&amp;type=commits</a></p>
<p>I guess they use <code>release</code></p>



<a name="217197111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197111">(Nov 18 2020 at 21:09)</a>:</h4>
<p>didn't see any so since it's not checked once committed :)</p>



<a name="217197209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197209">(Nov 18 2020 at 21:10)</a>:</h4>
<p>I'll do a merge commit with release</p>



<a name="217197221"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197221" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197221">(Nov 18 2020 at 21:10)</a>:</h4>
<p>and tag v0.2.0</p>



<a name="217197355"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197355" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197355">(Nov 18 2020 at 21:11)</a>:</h4>
<p>Yeah I haven't come up with a solution for a push check</p>



<a name="217197535"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197535" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197535">(Nov 18 2020 at 21:13)</a>:</h4>
<div class="codehilite"><pre><span></span><code>remote: error: GH006: Protected branch update failed for refs/heads/release.
remote: error: At least 3 approving reviews are required by reviewers with write access.
To github.com:pubgrub-rs/pubgrub.git
 ! [remote rejected] release -&gt; release (protected branch hook declined)
error: failed to push some refs to &#39;github.com:pubgrub-rs/pubgrub.git&#39;
</code></pre></div>



<a name="217197538"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197538" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197538">(Nov 18 2020 at 21:13)</a>:</h4>
<p>Maybe the answer in "GitHub pre commit hooks" search query</p>



<a name="217197540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197540">(Nov 18 2020 at 21:13)</a>:</h4>
<p>epic fail ahah</p>



<a name="217197550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197550">(Nov 18 2020 at 21:13)</a>:</h4>
<p>I guess I'll make a PR then ^^</p>



<a name="217197635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197635">(Nov 18 2020 at 21:14)</a>:</h4>
<p>Btw, are we going to add a merge commit or keep the history linear?</p>



<a name="217197660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197660">(Nov 18 2020 at 21:14)</a>:</h4>
<p>add merge commit</p>



<a name="217197756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197756">(Nov 18 2020 at 21:15)</a>:</h4>
<p>ah the PR to master triggers twice and tells me twice that the conventional commit is not good ahah</p>



<a name="217197871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197871">(Nov 18 2020 at 21:17)</a>:</h4>
<p>What should we do CI-master <span class="user-mention" data-user-id="340766">@Alex Tokarev</span> ?</p>



<a name="217197875"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217197875" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217197875">(Nov 18 2020 at 21:17)</a>:</h4>
<p>We can fix it in dev by force pushing. Also I need to whitelist <code>release</code> in conventional commit CI hook</p>



<a name="217198031"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198031" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198031">(Nov 18 2020 at 21:18)</a>:</h4>
<p>Can we authorize merge commit for the release branch while keeping rebase/squash behavior for the dev branch?</p>



<a name="217198095"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198095" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198095">(Nov 18 2020 at 21:19)</a>:</h4>
<p>I guess the message of the last commit should be:<br>
<code>feat!: prepare 0.2 version</code> or something along the lines?</p>



<a name="217198133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198133">(Nov 18 2020 at 21:19)</a>:</h4>
<p>Ah, as for master yes, we can allow merge commit strategy only there.</p>



<a name="217198258"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198258" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198258">(Nov 18 2020 at 21:20)</a>:</h4>
<blockquote>
<p>feat!: prepare 0.2 version or something along the lines?</p>
</blockquote>
<p>Could be. If you push to dev can you edit that commit then?</p>



<a name="217198289"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198289" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198289">(Nov 18 2020 at 21:21)</a>:</h4>
<p>Yes. I'll also whilelist <code>release</code> tag.</p>



<a name="217198522"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198522" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198522">(Nov 18 2020 at 21:23)</a>:</h4>
<p>Hm, is using<br>
<code>release: prepare 0.2 better</code>?</p>



<a name="217198653"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198653" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198653">(Nov 18 2020 at 21:24)</a>:</h4>
<p>I'd prefer <code>prepare butter</code></p>



<a name="217198773"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198773" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198773">(Nov 18 2020 at 21:25)</a>:</h4>
<p>This way we'll have 2 <code>release</code> commits per release though, hm</p>



<a name="217198874"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198874" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198874">(Nov 18 2020 at 21:26)</a>:</h4>
<p>it's ok only the one on release get tagged.</p>



<a name="217198967"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217198967" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217198967">(Nov 18 2020 at 21:26)</a>:</h4>
<p>A bit like some automated bots make dedicated commits for releases, except here it's attached to a branch</p>



<a name="217199142"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199142" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199142">(Nov 18 2020 at 21:28)</a>:</h4>
<p>Btw, I've noticed the following in the <code>release</code> branch:<br>
<a href="/user_uploads/4715/CbZvcFtVoXhdGdancAxBc4mz/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/CbZvcFtVoXhdGdancAxBc4mz/image.png" title="image.png"><img src="/user_uploads/4715/CbZvcFtVoXhdGdancAxBc4mz/image.png"></a></div>



<a name="217199216"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199216" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199216">(Nov 18 2020 at 21:29)</a>:</h4>
<p>not following?</p>



<a name="217199230"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199230" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199230">(Nov 18 2020 at 21:29)</a>:</h4>
<p>That means that these 5 commits are in dev, with an additional commit in release. So that "initial version" is in the middle of dev branch, but not there</p>



<a name="217199336"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199336" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199336">(Nov 18 2020 at 21:30)</a>:</h4>
<p>Am I right?</p>



<a name="217199484"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199484" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199484">(Nov 18 2020 at 21:31)</a>:</h4>
<p>Maybe it's not that <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span> Hm, why is it not linear there</p>



<a name="217199593"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199593" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199593">(Nov 18 2020 at 21:32)</a>:</h4>
<p>I'm not sure what you mean but its the last commit on release so they can represent it how they want</p>



<a name="217199744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199744">(Nov 18 2020 at 21:34)</a>:</h4>
<p><a href="/user_uploads/4715/jZWe0i9sDel2DgnakoWMeumC/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/jZWe0i9sDel2DgnakoWMeumC/image.png" title="image.png"><img src="/user_uploads/4715/jZWe0i9sDel2DgnakoWMeumC/image.png"></a></div>



<a name="217199815"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199815" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199815">(Nov 18 2020 at 21:34)</a>:</h4>
<p>This is what I mean. 5 commits above the selected one in the last screen shot are in the dev branch while skipping "Initial version..." one from release.</p>



<a name="217199829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199829">(Nov 18 2020 at 21:35)</a>:</h4>
<p>It was cut out too early</p>



<a name="217199846"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199846" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199846">(Nov 18 2020 at 21:35)</a>:</h4>
<p>ahh I think I see what you mean</p>



<a name="217199865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199865">(Nov 18 2020 at 21:35)</a>:</h4>
<p>I can drop them from dev</p>



<a name="217199951"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217199951" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217199951">(Nov 18 2020 at 21:36)</a>:</h4>
<p>ahah it's ok, we can just follow things from now on</p>



<a name="217200053"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217200053" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217200053">(Nov 18 2020 at 21:37)</a>:</h4>
<p>Maybe I'm just misunderstanding something <span aria-label="sleeping" class="emoji emoji-1f634" role="img" title="sleeping">:sleeping:</span> Ok, whatever</p>



<a name="217200077"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217200077" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217200077">(Nov 18 2020 at 21:37)</a>:</h4>
<p><a href="https://github.com/pubgrub-rs/pubgrub/network">https://github.com/pubgrub-rs/pubgrub/network</a></p>



<a name="217200279"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217200279" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217200279">(Nov 18 2020 at 21:39)</a>:</h4>
<p>Damn, it's just a merge commit</p>



<a name="217200291"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217200291" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217200291">(Nov 18 2020 at 21:39)</a>:</h4>
<p>Sorry I'm sleepy I guess))</p>



<a name="217200706"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217200706" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217200706">(Nov 18 2020 at 21:44)</a>:</h4>
<p>Let's wait until tomorrow then, we can just change the release date tomorrow and finish it up then</p>



<a name="217200836"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217200836" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217200836">(Nov 18 2020 at 21:45)</a>:</h4>
<p>BTW, just got off the Cargo Team meeting, they are all excited to see the release!</p>



<a name="217201023"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201023" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201023">(Nov 18 2020 at 21:47)</a>:</h4>
<p><a href="/user_uploads/4715/In9bU6Ddm2sUlQyD_FgvenTP/image.png">image.png</a> </p>
<div class="message_inline_image"><a href="/user_uploads/4715/In9bU6Ddm2sUlQyD_FgvenTP/image.png" title="image.png"><img src="/user_uploads/4715/In9bU6Ddm2sUlQyD_FgvenTP/image.png"></a></div><p>ahahah that thing is a troll</p>



<a name="217201108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201108">(Nov 18 2020 at 21:48)</a>:</h4>
<p><span class="user-mention" data-user-id="340766">@Alex Tokarev</span> you should restrict CI for PR in the dev branch</p>



<a name="217201131"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201131" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201131">(Nov 18 2020 at 21:48)</a>:</h4>
<p>I thought it's because PR was made before I whitelisted <code>release</code> type</p>



<a name="217201185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201185">(Nov 18 2020 at 21:48)</a>:</h4>
<p>ah, don't know ...</p>



<a name="217201348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201348">(Nov 18 2020 at 21:50)</a>:</h4>
<p>I guess not, it's complaining about an old commit</p>



<a name="217201358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201358">(Nov 18 2020 at 21:50)</a>:</h4>
<p>I think if you restrict</p>
<div class="codehilite"><pre><span></span><code>name: CI
on:
  pull_request:
    branches: [ dev ]
</code></pre></div>



<a name="217201376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201376">(Nov 18 2020 at 21:50)</a>:</h4>
<p>that should make it happy and prevent double CI</p>



<a name="217201641"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201641" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201641">(Nov 18 2020 at 21:53)</a>:</h4>
<p>I can also relax our conventional messages config while we are at it</p>



<a name="217201752"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201752" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201752">(Nov 18 2020 at 21:54)</a>:</h4>
<p>So it complains about too long body length. I see there is a link in a commit message:</p>
<div class="codehilite"><pre><span></span><code>https://github.com/dart-lang/pub/blob/23a59a380cdc88aca6a50f9b0147ecdd3b948919/lib/src/solver/incompatibility.dart#L68
</code></pre></div>
<p>Well it's a legit usecase, so we can drop 72 symbols restriction from body lines I think</p>



<a name="217201964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217201964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217201964">(Nov 18 2020 at 21:56)</a>:</h4>
<blockquote>
<p>footer must have leading blank line</p>
</blockquote>
<p>But... There is no footer in that commit message.</p>



<a name="217202002"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217202002" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217202002">(Nov 18 2020 at 21:57)</a>:</h4>
<p>The errors are in <code>fix: fix the wrong implementation of prior_cause (#23)</code></p>



<a name="217202300"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217202300" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217202300">(Nov 18 2020 at 21:59)</a>:</h4>
<p>yeah making it just a warning might be a better option</p>



<a name="217204250"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217204250" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217204250">(Nov 18 2020 at 22:16)</a>:</h4>
<p>Done</p>



<a name="217204273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217204273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217204273">(Nov 18 2020 at 22:17)</a>:</h4>
<p>Now our linting is not nazi anymore</p>



<a name="217204307"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217204307" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217204307">(Nov 18 2020 at 22:17)</a>:</h4>
<p>3 approval is impossible ^^ I can't approve my own pr :)</p>



<a name="217204313"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217204313" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217204313">(Nov 18 2020 at 22:17)</a>:</h4>
<p>Well, maybe much less so <span aria-label="grinning face with smiling eyes" class="emoji emoji-1f601" role="img" title="grinning face with smiling eyes">:grinning_face_with_smiling_eyes:</span></p>



<a name="217204353"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217204353" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217204353">(Nov 18 2020 at 22:17)</a>:</h4>
<p>1 or 2?</p>



<a name="217204429"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217204429" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217204429">(Nov 18 2020 at 22:18)</a>:</h4>
<p>2 better</p>



<a name="217204528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217204528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217204528">(Nov 18 2020 at 22:19)</a>:</h4>
<p>Changed</p>



<a name="217204755"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217204755" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217204755">(Nov 18 2020 at 22:21)</a>:</h4>
<p>Regarding double CI, it shouldn't happen in the future unless we open the MR to <code>release</code> and then have this much fun with <code>dev</code> at the same time.</p>



<a name="217204935"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217204935" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217204935">(Nov 18 2020 at 22:22)</a>:</h4>
<p>I changed 2 files if you are curious: .commitlintrc.yml and ci.yml</p>



<a name="217205278"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217205278" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217205278">(Nov 18 2020 at 22:25)</a>:</h4>
<p><a href="/user_uploads/4715/yl6PT_AmMwZ0ZLpA1z9XwOKA/image.png">image.png</a> </p>
<div class="message_inline_image"><a href="/user_uploads/4715/yl6PT_AmMwZ0ZLpA1z9XwOKA/image.png" title="image.png"><img src="/user_uploads/4715/yl6PT_AmMwZ0ZLpA1z9XwOKA/image.png"></a></div><p>I've added the merge commit button to be able to merge to release with a merge commit</p>



<a name="217205374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217205374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217205374">(Nov 18 2020 at 22:26)</a>:</h4>
<p>Ah, I changed another option to allow merge commits in release branch, I guess it wasn't enough</p>



<a name="217205440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217205440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217205440">(Nov 18 2020 at 22:26)</a>:</h4>
<p><a href="/user_uploads/4715/NkeoJnWcWTQ9_yniN3dQleMa/image.png">image.png</a> </p>
<div class="message_inline_image"><a href="/user_uploads/4715/NkeoJnWcWTQ9_yniN3dQleMa/image.png" title="image.png"><img src="/user_uploads/4715/NkeoJnWcWTQ9_yniN3dQleMa/image.png"></a></div><p>Since we have that in the dev branch setup, it should not be possible to use the merge button for a PR to dev I think (not sure)</p>



<a name="217205518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217205518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217205518">(Nov 18 2020 at 22:27)</a>:</h4>
<p>All should be good now on <span class="user-mention" data-user-id="120179">@Eh2406</span>  approval</p>



<a name="217205645"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217205645" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217205645">(Nov 18 2020 at 22:28)</a>:</h4>
<p>That's what I removed from <code>release</code> branch config today I think</p>



<a name="217207411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217207411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217207411">(Nov 18 2020 at 22:47)</a>:</h4>
<p>I totally imagine <span class="user-mention" data-user-id="348419">@Matthieu Pizenberg</span> hovering over all publishing buttons on Github, Reddit and Discourse simultaneously atm</p>



<a name="217207464"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217207464" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217207464">(Nov 18 2020 at 22:47)</a>:</h4>
<p>ahahah</p>



<a name="217207539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217207539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217207539">(Nov 18 2020 at 22:48)</a>:</h4>
<p>Or maybe furiously moving a mouse between them?</p>



<a name="217207544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217207544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217207544">(Nov 18 2020 at 22:48)</a>:</h4>
<p><a href="/user_uploads/4715/nGOzRYtl5EjWpKGxJLhAkQMl/image.png">image.png</a> </p>
<div class="message_inline_image"><a href="/user_uploads/4715/nGOzRYtl5EjWpKGxJLhAkQMl/image.png" title="image.png"><img src="/user_uploads/4715/nGOzRYtl5EjWpKGxJLhAkQMl/image.png"></a></div><p>Actually I'm just looking at some blender tutorial</p>



<a name="217207656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217207656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217207656">(Nov 18 2020 at 22:49)</a>:</h4>
<p>Nice! What would you like to create 3d models for?</p>



<a name="217207791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217207791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217207791">(Nov 18 2020 at 22:51)</a>:</h4>
<p>I'm kind of generally interested in 3D because of my work and since 3d is just cool really.<br>
And recently I've gotten back to blender and it's way nicer than few years ago</p>



<a name="217207906"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217207906" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217207906">(Nov 18 2020 at 22:52)</a>:</h4>
<p>What have you been using in the mean time? 3DMax?</p>



<a name="217208058"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208058" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208058">(Nov 18 2020 at 22:54)</a>:</h4>
<p>Nothing for at least 8 or 9 years</p>



<a name="217208086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208086">(Nov 18 2020 at 22:54)</a>:</h4>
<p>or maybe 6 years rather</p>



<a name="217208125"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208125" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208125">(Nov 18 2020 at 22:55)</a>:</h4>
<blockquote>
<p>3d is just cool really.</p>
</blockquote>
<p>True. I remember my neighbor impressed me as a kid by quickly creating a cool Roman helmet in 3DMax while I was standing right next to him.</p>
<p>Too bad I have no idea where I would apply that knowledge so I never played with it myself.</p>



<a name="217208311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208311">(Nov 18 2020 at 22:56)</a>:</h4>
<p>I remember doing a little bit of sketchup some time ago, just to find ways to change how things are placed in my room</p>



<a name="217208327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208327">(Nov 18 2020 at 22:57)</a>:</h4>
<p>And there wasn't much options XD</p>



<a name="217208439"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208439" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208439">(Nov 18 2020 at 22:58)</a>:</h4>
<p>my parents are making dedicated dressings also so I used to show them how to use sketchup for their client drawings</p>



<a name="217208477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208477">(Nov 18 2020 at 22:58)</a>:</h4>
<p>Haha. But that was a cool idea!</p>
<blockquote>
<p>dedicated dressings</p>
</blockquote>
<p>Dressings for what?</p>



<a name="217208513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208513">(Nov 18 2020 at 22:59)</a>:</h4>
<p>woops<br>
lost in translation</p>



<a name="217208652"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208652" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208652">(Nov 18 2020 at 23:01)</a>:</h4>
<p>walk-in wardrobe I think that's called</p>



<a name="217208704"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208704" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208704">(Nov 18 2020 at 23:01)</a>:</h4>
<p>"dressing" is the french world and since it sounded english I assumed that could be the same</p>



<a name="217208714"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208714" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208714">(Nov 18 2020 at 23:01)</a>:</h4>
<p>Ah. "Dressing room" is also fine</p>



<a name="217208877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217208877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217208877">(Nov 18 2020 at 23:03)</a>:</h4>
<p>I should have guessed, but "dressing" without "room" also has a (different) meaning. Like "salad dressings" <span aria-label="grinning face with smiling eyes" class="emoji emoji-1f601" role="img" title="grinning face with smiling eyes">:grinning_face_with_smiling_eyes:</span></p>



<a name="217209380"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217209380" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217209380">(Nov 18 2020 at 23:10)</a>:</h4>
<p>While we have time to think about the release... Maybe we should sign our tags?</p>



<a name="217209487"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217209487" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217209487">(Nov 18 2020 at 23:11)</a>:</h4>
<p>never done that</p>



<a name="217209626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217209626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217209626">(Nov 18 2020 at 23:13)</a>:</h4>
<p>Basically it's to verify that what we have released has not been altered. I also haven't done that since I hadn't released anything <span aria-label="grinning face with smiling eyes" class="emoji emoji-1f601" role="img" title="grinning face with smiling eyes">:grinning_face_with_smiling_eyes:</span> , but it's not complicated so I think I can do it if we want to.</p>



<a name="217209771"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217209771" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217209771">(Nov 18 2020 at 23:15)</a>:</h4>
<p>You need a GPG key though, I have never setup one yet</p>



<a name="217209784"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217209784" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217209784">(Nov 18 2020 at 23:15)</a>:</h4>
<p>The question is how do we share the key so any one of us could sign it in the future. Or maybe it should be personal, hm. The release would then show who exactly signed it. I'll look into it.</p>



<a name="217209912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217209912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217209912">(Nov 18 2020 at 23:17)</a>:</h4>
<p>Github has instructions for signing here <a href="https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/managing-commit-signature-verification">https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/managing-commit-signature-verification</a><br>
And GPG generation is linked from there as well:<br>
<a href="https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/generating-a-new-gpg-key">https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/generating-a-new-gpg-key</a></p>



<a name="217209992"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217209992" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217209992">(Nov 18 2020 at 23:18)</a>:</h4>
<p>So they provide step by step instructions for everything in the first link</p>



<a name="217210005"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217210005" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217210005">(Nov 18 2020 at 23:18)</a>:</h4>
<p>Yes these keys need to be personal I think since the private part should not be shared</p>



<a name="217210059"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217210059" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217210059">(Nov 18 2020 at 23:18)</a>:</h4>
<p>Maybe "team-private" is also fine</p>



<a name="217210089"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217210089" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217210089">(Nov 18 2020 at 23:19)</a>:</h4>
<p>But that I can't answer right now</p>



<a name="217210194"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217210194" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217210194">(Nov 18 2020 at 23:20)</a>:</h4>
<p>going to bed, getting quite tired<br>
good night!</p>



<a name="217210251"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217210251" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217210251">(Nov 18 2020 at 23:21)</a>:</h4>
<p>Me too, I'm falling asleep. <span class="user-mention" data-user-id="120179">@Eh2406</span> You can do the release honors when you are back</p>



<a name="217210311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217210311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217210311">(Nov 18 2020 at 23:22)</a>:</h4>
<p>Or we can wait till tomorrow and change the release date. It has already changed in my timezone.</p>



<a name="217210368"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217210368" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217210368">(Nov 18 2020 at 23:22)</a>:</h4>
<p>Good night!</p>



<a name="217210756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217210756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217210756">(Nov 18 2020 at 23:27)</a>:</h4>
<p>yep, Jacob should do the release to test the permissions settings anyway but we can wait for a better timing tomorrow when all three of us are awake and fresh ^^</p>



<a name="217215677"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217215677" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217215677">(Nov 19 2020 at 00:28)</a>:</h4>
<p>Sorry was busy running an errand. I will be on tomorrow morning.</p>



<a name="217253465"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217253465" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217253465">(Nov 19 2020 at 10:51)</a>:</h4>
<p><span class="user-mention" data-user-id="340766">@Alex Tokarev</span> How were you able to push to dev? I've tried a few config changes to update the release date but it failed everytime</p>



<a name="217254073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217254073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217254073">(Nov 19 2020 at 10:58)</a>:</h4>
<p>found :)</p>



<a name="217254286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217254286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217254286">(Nov 19 2020 at 11:00)</a>:</h4>
<p>2 settings changes: allow force pushes and disable required reviews</p>



<a name="217254359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217254359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217254359">(Nov 19 2020 at 11:01)</a>:</h4>
<p>did all force pushes and include admin</p>



<a name="217254394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217254394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217254394">(Nov 19 2020 at 11:01)</a>:</h4>
<p>You'll have to valid again</p>



<a name="217255545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217255545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217255545">(Nov 19 2020 at 11:13)</a>:</h4>
<p>You already did it but maybe <span class="user-mention" data-user-id="120179">@Eh2406</span> is also curious so <a href="/user_uploads/4715/_e1U4FWWkkCGbLlu35DZi8Pa/Screenshot_20201119_140200.png">Screenshot_20201119_140200.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/_e1U4FWWkkCGbLlu35DZi8Pa/Screenshot_20201119_140200.png" title="Screenshot_20201119_140200.png"><img src="/user_uploads/4715/_e1U4FWWkkCGbLlu35DZi8Pa/Screenshot_20201119_140200.png"></a></div>



<a name="217255728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217255728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217255728">(Nov 19 2020 at 11:15)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217254394">said</a>:</p>
<blockquote>
<p>You'll have to valid again</p>
</blockquote>
<p>That is controlled by this setting btw <a href="/user_uploads/4715/PjoARcjoosXNg8MNLU10gMor/Screenshot_20201119_141442.png">Screenshot_20201119_141442.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/PjoARcjoosXNg8MNLU10gMor/Screenshot_20201119_141442.png" title="Screenshot_20201119_141442.png"><img src="/user_uploads/4715/PjoARcjoosXNg8MNLU10gMor/Screenshot_20201119_141442.png"></a></div>



<a name="217255853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217255853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217255853">(Nov 19 2020 at 11:16)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217254359">said</a>:</p>
<blockquote>
<p>did all force pushes and include admin</p>
</blockquote>
<p>What changed btw?</p>



<a name="217256842"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217256842" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217256842">(Nov 19 2020 at 11:26)</a>:</h4>
<p>I have found a way to perform the comparison, only this line changed:<br>
<code>## [0.2.0] - 2020-11-19 - [(diff with 0.1.0)][diff-0.2.0]</code></p>



<a name="217257008"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217257008" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217257008">(Nov 19 2020 at 11:29)</a>:</h4>
<p>yep only the date</p>



<a name="217258136"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217258136" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217258136">(Nov 19 2020 at 11:41)</a>:</h4>
<p><a href="https://crates.io/crates/pubgrub">https://crates.io/crates/pubgrub</a><br>
When did crates-io team became an owner?</p>



<a name="217258242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217258242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217258242">(Nov 19 2020 at 11:42)</a>:</h4>
<p>Ahhh, it's our organization, not crates-io team</p>



<a name="217258580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217258580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217258580">(Nov 19 2020 at 11:46)</a>:</h4>
<p>Yes I created that team in the pubgrub-rs org: <a href="https://github.com/orgs/pubgrub-rs/teams">https://github.com/orgs/pubgrub-rs/teams</a></p>



<a name="217258668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217258668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217258668">(Nov 19 2020 at 11:48)</a>:</h4>
<p>you cannot give crates-io owner rights to a GitHub org, but you can to a team in an org. So I created a dedicated team in the pubgrub-rs org with rights to publish on crates-io</p>



<a name="217258716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217258716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217258716">(Nov 19 2020 at 11:48)</a>:</h4>
<p>called it "crates-io" :)</p>



<a name="217258797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217258797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217258797">(Nov 19 2020 at 11:49)</a>:</h4>
<p>This is what confused me<br>
<a href="/user_uploads/4715/LFbev9ie1g_H1K9JJiKCEPWY/Screenshot_20201119_144743.png">Screenshot_20201119_144743.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/LFbev9ie1g_H1K9JJiKCEPWY/Screenshot_20201119_144743.png" title="Screenshot_20201119_144743.png"><img src="/user_uploads/4715/LFbev9ie1g_H1K9JJiKCEPWY/Screenshot_20201119_144743.png"></a></div>



<a name="217258893"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217258893" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217258893">(Nov 19 2020 at 11:50)</a>:</h4>
<p>It made me think that an actual crates-io team (the one managing the site) is an owner of our crate</p>



<a name="217280043"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280043" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280043">(Nov 19 2020 at 14:56)</a>:</h4>
<p>Hi! I am up and started. Looks like things ended up waiting on me. Sorry.<br>
How can I help?</p>



<a name="217280132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280132">(Nov 19 2020 at 14:56)</a>:</h4>
<p>hi :)</p>



<a name="217280195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280195">(Nov 19 2020 at 14:57)</a>:</h4>
<p>So basically, I updated the release date to today</p>



<a name="217280258"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280258" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280258">(Nov 19 2020 at 14:57)</a>:</h4>
<p>so you need to re-validate the PR (it is setup to invalidate reviews on push)</p>



<a name="217280390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280390">(Nov 19 2020 at 14:58)</a>:</h4>
<p>We'll merge the PR to release with a merge commit (no squash or rebase)</p>



<a name="217280459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280459">(Nov 19 2020 at 14:59)</a>:</h4>
<p>then we can tag it v0.2.0 and you can try publishing on crates to check the team setup</p>



<a name="217280501"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280501" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280501">(Nov 19 2020 at 14:59)</a>:</h4>
<p>I also want to sign the tags</p>



<a name="217280535"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280535" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280535">(Nov 19 2020 at 14:59)</a>:</h4>
<p>Approved and merged.</p>



<a name="217280548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280548">(Nov 19 2020 at 14:59)</a>:</h4>
<p>Not sure if 0.1 needs to be signed before creating 0.2 tag</p>



<a name="217280976"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217280976" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217280976">(Nov 19 2020 at 15:02)</a>:</h4>
<p>Do you want to do the tag to make sure it is signed as you want?</p>



<a name="217281055"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217281055" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217281055">(Nov 19 2020 at 15:03)</a>:</h4>
<p>Yes I can do that</p>



<a name="217281171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217281171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217281171">(Nov 19 2020 at 15:04)</a>:</h4>
<p>Give me a moment, I'll generate PGP key, see if I can sign the previous tag and a new one</p>



<a name="217281604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217281604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217281604">(Nov 19 2020 at 15:07)</a>:</h4>
<p><span class="user-mention" data-user-id="340766">@Alex Tokarev</span> what are the exact implications of signing a tag?</p>



<a name="217281792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217281792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217281792">(Nov 19 2020 at 15:08)</a>:</h4>
<p>I think it verifiably means that that tag was created by someone with access to that PGP key.</p>



<a name="217281840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217281840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217281840">(Nov 19 2020 at 15:08)</a>:</h4>
<p>It provides a way to verify with public key that our release has not been tampered with.</p>



<a name="217281949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217281949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217281949">(Nov 19 2020 at 15:09)</a>:</h4>
<p>It's somewhat like a checksum in it's purpose</p>



<a name="217282019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282019">(Nov 19 2020 at 15:10)</a>:</h4>
<p>But the one that uses cryptography</p>



<a name="217282056"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282056" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282056">(Nov 19 2020 at 15:10)</a>:</h4>
<p>As long as you trust the owner of the public key right?</p>



<a name="217282132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282132">(Nov 19 2020 at 15:10)</a>:</h4>
<p>...the owner of private key. Because public key is available to everyone, but private should be kept in secret.</p>



<a name="217282280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282280">(Nov 19 2020 at 15:11)</a>:</h4>
<p>If you think we don't need that we can skip this part</p>



<a name="217282287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282287">(Nov 19 2020 at 15:11)</a>:</h4>
<p>yes, so you have to not ever loose the private key you used to sign this tag. Is this realistic for long term usage?</p>



<a name="217282359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282359">(Nov 19 2020 at 15:12)</a>:</h4>
<p>Just trying to understand the implications of that</p>



<a name="217282425"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282425" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282425">(Nov 19 2020 at 15:12)</a>:</h4>
<p>Well, that's what everyone is doing for the packages you pull from your distro's package manager, if you use Linux</p>



<a name="217282435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282435">(Nov 19 2020 at 15:12)</a>:</h4>
<p>For email I can understand that you want to make sure that the message you just received was just signed by the right person</p>



<a name="217282458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282458">(Nov 19 2020 at 15:13)</a>:</h4>
<p>So if a different public key is used for the next release. Someone can see that it was not tagged by Alex. And start investigating if it was Me or You or Alex's new key and so is Ok, or it is hakker and is not OK.</p>



<a name="217282463"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282463" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282463">(Nov 19 2020 at 15:13)</a>:</h4>
<p>I see</p>



<a name="217282481"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282481" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282481">(Nov 19 2020 at 15:13)</a>:</h4>
<p>If it is leaked, you invalidate the key and resign with a new one I guess</p>



<a name="217282522"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282522" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282522">(Nov 19 2020 at 15:13)</a>:</h4>
<p>alright, other question</p>



<a name="217282558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282558">(Nov 19 2020 at 15:14)</a>:</h4>
<p>isn't the tag just metadata for the commit?</p>



<a name="217282635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282635">(Nov 19 2020 at 15:14)</a>:</h4>
<p>is cargo using the tag at all?</p>



<a name="217282683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282683">(Nov 19 2020 at 15:14)</a>:</h4>
<p>Yes basically people downloading the crate store "trusted" keys in their database. So if they see it is signed by Alex, and I am in maintainers list, sounds like a good reason to trust the person (add the key to the trusted keys database)</p>



<a name="217282749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282749">(Nov 19 2020 at 15:15)</a>:</h4>
<p>Yes, but part of the metadata is the hash of the commit. So a signed tag endorses the commit.</p>



<a name="217282837"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282837" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282837">(Nov 19 2020 at 15:15)</a>:</h4>
<blockquote>
<p>Yes, but part of the metadata is the hash of the commit. So a signed tag endorses the commit</p>
</blockquote>
<p>alright :) thanks</p>



<a name="217282855"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282855" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282855">(Nov 19 2020 at 15:15)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217282558">said</a>:</p>
<blockquote>
<p>isn't the tag just metadata for the commit?</p>
</blockquote>
<p>It is, but what you are saying when you sign the tag is: "I verify that I trust all previous commits, they come from who they say they come from and they haven't been tampered with".</p>



<a name="217282957"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217282957" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217282957">(Nov 19 2020 at 15:16)</a>:</h4>
<p>Unfortunately, yes there needs to be a separate process to verify that what I publish to <a href="http://crates.io">crates.io</a> has anything to do with the tag.</p>



<a name="217283019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283019">(Nov 19 2020 at 15:16)</a>:</h4>
<p>If you then change a previous commit and force push, tag checking would fail in my understanding.</p>



<a name="217283106"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283106" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283106">(Nov 19 2020 at 15:17)</a>:</h4>
<p>We can do a quick check not with the master branch just to see if this does what we think it does</p>



<a name="217283254"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283254" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283254">(Nov 19 2020 at 15:18)</a>:</h4>
<p>I create a dummy commit, push it to some branch, create a tag after that and sign it. We can see if we can verify it and how it's done.<br>
Then I alter the commit and you can try to verify it again.</p>



<a name="217283449"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283449" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283449">(Nov 19 2020 at 15:19)</a>:</h4>
<p>The reason I was worried for needing to sign a previous tag is: what if signing 0.1 after 0.2 changes the hash and you can't verify 0.2 anymore without resigning?</p>



<a name="217283559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283559">(Nov 19 2020 at 15:20)</a>:</h4>
<p>Tags do not change commits.</p>



<a name="217283564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283564">(Nov 19 2020 at 15:20)</a>:</h4>
<p>Since this is also a new thing to me (I'm learning alongside you), I can't answer yet <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span> I would think it does.</p>



<a name="217283626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283626">(Nov 19 2020 at 15:21)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120179">Eh2406</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217283559">said</a>:</p>
<blockquote>
<p>Tags do not change commits.</p>
</blockquote>
<p>Do they contain info about previous tags?</p>



<a name="217283719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283719">(Nov 19 2020 at 15:21)</a>:</h4>
<p>If 0.2 tag includes info about 0.1 tag, then I'm right to worry. If it does not and they are completely independent, then we can sign whenever.</p>



<a name="217283819"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283819" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283819">(Nov 19 2020 at 15:22)</a>:</h4>
<p>I don't think so, tags are not ordered in any way. It is just a flag "this commit is interesting".</p>



<a name="217283901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283901">(Nov 19 2020 at 15:22)</a>:</h4>
<p><span class="user-mention silent" data-user-id="340766">Alex Tokarev</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217283254">said</a>:</p>
<blockquote>
<p>I create a dummy commit, push it to some branch, create a tag after that and sign it. We can see if we can verify it and how it's done.<br>
Then I alter the commit and you can try to verify it again.</p>
</blockquote>
<p>Alright. Do we want to do this for fun and learning?</p>



<a name="217283931"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283931" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283931">(Nov 19 2020 at 15:23)</a>:</h4>
<p>yep you can do it</p>



<a name="217283999"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217283999" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217283999">(Nov 19 2020 at 15:23)</a>:</h4>
<p>I also don't want to hold the release, so maybe we can release first if you feel like this is somewhat a waste of time</p>



<a name="217284103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217284103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217284103">(Nov 19 2020 at 15:24)</a>:</h4>
<p>But since it's independent of the crates publishing process if I understood correctly, we can also do it whenever I guess</p>



<a name="217284413"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217284413" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217284413">(Nov 19 2020 at 15:26)</a>:</h4>
<p>Ok, I will work on the <a href="http://crates.io">crates.io</a> release. Feel free to experiment as needed to get the tag up, but let's make sure the github release happens today.</p>



<a name="217284494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217284494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217284494">(Nov 19 2020 at 15:26)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217284103">said</a>:</p>
<blockquote>
<p>But since it's independent of the crates publishing process if I understood correctly, we can also do it whenever I guess</p>
</blockquote>
<p>Well I just hope so <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="217284875"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217284875" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217284875">(Nov 19 2020 at 15:29)</a>:</h4>
<p>It would not be a release unless we bungled up something. :-)</p>



<a name="217285070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217285070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217285070">(Nov 19 2020 at 15:30)</a>:</h4>
<p><span class="user-mention" data-user-id="120179">@Eh2406</span> <a href="https://doc.rust-lang.org/cargo/reference/publishing.html">https://doc.rust-lang.org/cargo/reference/publishing.html</a></p>



<a name="217285144"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217285144" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217285144">(Nov 19 2020 at 15:31)</a>:</h4>
<p>(make sure to update you release branch before ^^)</p>



<a name="217285267"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217285267" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217285267">(Nov 19 2020 at 15:31)</a>:</h4>
<p>good call. and thanks for the link. I was checking it out then going to look for that link.</p>



<a name="217286242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286242">(Nov 19 2020 at 15:38)</a>:</h4>
<div class="codehilite"><pre><span></span><code>&gt;cargo publish --dry-run
    Updating crates.io index
   Packaging pubgrub v0.2.0 (MyProjects\pubgrub\pubgrub-rs)
   Verifying pubgrub v0.2.0 (MyProjects\pubgrub\pubgrub-rs)
error: failed to verify package tarball

Caused by:
  failed to parse manifest at `MyProjects\pubgrub\pubgrub-rs\target\package\pubgrub-0.2.0\Cargo.toml`

Caused by:
  can&#39;t find `large_case` bench, specify bench.path`
</code></pre></div>



<a name="217286396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286396">(Nov 19 2020 at 15:39)</a>:</h4>
<p>damn we need to package it?</p>



<a name="217286419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286419">(Nov 19 2020 at 15:39)</a>:</h4>
<p>changing to <code>include = ["Cargo.toml", "LICENSE", "README.md", "src/**", "tests/**", "examples/**", "bench/**"]</code></p>



<a name="217286468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286468">(Nov 19 2020 at 15:39)</a>:</h4>
<p>just the .rs file not the ron files</p>



<a name="217286490"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286490" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286490">(Nov 19 2020 at 15:39)</a>:</h4>
<p>Hah !</p>



<a name="217286497"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286497" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286497">(Nov 19 2020 at 15:39)</a>:</h4>
<p>ok</p>



<a name="217286566"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286566" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286566">(Nov 19 2020 at 15:40)</a>:</h4>
<p>Do dev dependencies need to be published? <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="217286631"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286631" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286631">(Nov 19 2020 at 15:40)</a>:</h4>
<blockquote>
<p>It would not be a release unless we bungled up something. :-)</p>
</blockquote>
<p>It was foretold ...</p>



<a name="217286681"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286681" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286681">(Nov 19 2020 at 15:41)</a>:</h4>
<p>Might as well package Ron, since benchmark is useless otherwise.</p>



<a name="217286733"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286733" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286733">(Nov 19 2020 at 15:41)</a>:</h4>
<blockquote>
<p>Might as well package Ron, since benchmark is useless otherwise.</p>
</blockquote>
<p>nope that gets downloaded by everyone</p>



<a name="217286835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286835">(Nov 19 2020 at 15:42)</a>:</h4>
<p>I think it's ok, they can get it from the github repo if they want anyway</p>



<a name="217286856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286856">(Nov 19 2020 at 15:42)</a>:</h4>
<p>Can we exclude tests and benches then from release?</p>



<a name="217286901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286901">(Nov 19 2020 at 15:42)</a>:</h4>
<p>the issue is it's in the Cargo.toml</p>



<a name="217286950"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217286950" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217286950">(Nov 19 2020 at 15:42)</a>:</h4>
<p>so I don't think you can not include it</p>



<a name="217287211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217287211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217287211">(Nov 19 2020 at 15:44)</a>:</h4>
<p>I'd say the simplest solution is 1 commit that adds "bench/**" to include. force push to master and call it a day</p>



<a name="217287293"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217287293" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217287293">(Nov 19 2020 at 15:45)</a>:</h4>
<p>When I have a commit that is working I will make a PR.</p>



<a name="217287697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217287697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217287697">(Nov 19 2020 at 15:47)</a>:</h4>
<blockquote>
<p>force push to master and call it a day</p>
</blockquote>
<p>I'd even go as far as "call it a release day"</p>



<a name="217288455"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217288455" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217288455">(Nov 19 2020 at 15:52)</a>:</h4>
<p>reminder! next time do the <code>cargo publish --dry-run</code> in the prepration commit XD</p>



<a name="217288578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217288578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217288578">(Nov 19 2020 at 15:52)</a>:</h4>
<p>Do we wont to add it to CI, for PR's to release?</p>



<a name="217288669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217288669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217288669">(Nov 19 2020 at 15:53)</a>:</h4>
<p>could be useful indeed</p>



<a name="217288932"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217288932" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217288932">(Nov 19 2020 at 15:55)</a>:</h4>
<p>We can add it later</p>



<a name="217289029"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289029" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289029">(Nov 19 2020 at 15:55)</a>:</h4>
<blockquote>
<p>I'd even go as far as "call it a release day"</p>
</blockquote>
<p>Will you do that? The options you need to disable are in <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217255545">https://rust-lang.zulipchat.com/#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217255545</a></p>



<a name="217289118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289118">(Nov 19 2020 at 15:56)</a>:</h4>
<blockquote>
<p>We can add it later</p>
</blockquote>
<p>I like that thinking ahah</p>



<a name="217289187"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289187" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289187">(Nov 19 2020 at 15:56)</a>:</h4>
<blockquote>
<p>Will you do that?</p>
</blockquote>
<p>nah waiting for Jacob</p>



<a name="217289244"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289244" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289244">(Nov 19 2020 at 15:57)</a>:</h4>
<p>Well it won't work anyway since it's not going to be a PR <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span></p>



<a name="217289281"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289281" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289281">(Nov 19 2020 at 15:57)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217289187">said</a>:</p>
<blockquote>
<blockquote>
<p>Will you do that?</p>
</blockquote>
<p>nah waiting for Jacob</p>
</blockquote>
<p>Damn I was thinking I was replying to Jacob's message</p>



<a name="217289432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289432">(Nov 19 2020 at 15:58)</a>:</h4>
<p>Pr to dev: <a href="https://github.com/pubgrub-rs/pubgrub/pull/68">https://github.com/pubgrub-rs/pubgrub/pull/68</a></p>



<a name="217289628"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289628" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289628">(Nov 19 2020 at 15:59)</a>:</h4>
<p>Hello from Clippy <span aria-label="joy" class="emoji emoji-1f602" role="img" title="joy">:joy:</span></p>



<a name="217289673"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289673" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289673">(Nov 19 2020 at 16:00)</a>:</h4>
<p>ahahah the elements are against this thing</p>



<a name="217289814"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289814" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289814">(Nov 19 2020 at 16:00)</a>:</h4>
<p>"How many engineers do you need to release a crate?"</p>



<a name="217289826"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289826" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289826">(Nov 19 2020 at 16:00)</a>:</h4>
<p>That clippy check is just wrong for why we are using RC.</p>



<a name="217289882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289882">(Nov 19 2020 at 16:01)</a>:</h4>
<p>Actually this is why we are not using nightly clippy</p>



<a name="217289923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289923">(Nov 19 2020 at 16:01)</a>:</h4>
<p>That lint showed an issue before</p>



<a name="217289949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217289949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217289949">(Nov 19 2020 at 16:01)</a>:</h4>
<p>That it appeared, broke the build and then they removed it</p>



<a name="217290005"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217290005" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217290005">(Nov 19 2020 at 16:01)</a>:</h4>
<p>There was just a new release of rust.</p>



<a name="217290027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217290027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217290027">(Nov 19 2020 at 16:01)</a>:</h4>
<p>See <a href="#narrow/stream/257328-clippy/topic/rc_buffer/near/213311158">https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/rc_buffer/near/213311158</a></p>



<a name="217290237"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217290237" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217290237">(Nov 19 2020 at 16:03)</a>:</h4>
<p>I think we should run clippy with beta as well, but not fail the build on warnings to give us some time to check for the surprises.</p>



<a name="217290348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217290348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217290348">(Nov 19 2020 at 16:03)</a>:</h4>
<p>Well, let me fix the whole thing quickly (don't look <span aria-label="smiling devil" class="emoji emoji-1f608" role="img" title="smiling devil">:smiling_devil:</span> )</p>



<a name="217290570"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217290570" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217290570">(Nov 19 2020 at 16:04)</a>:</h4>
<p>What I was thinking of doing is amending previous dev commit, then doing that for the release branch</p>



<a name="217290620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217290620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217290620">(Nov 19 2020 at 16:05)</a>:</h4>
<p>looking away</p>



<a name="217291265"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217291265" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217291265">(Nov 19 2020 at 16:09)</a>:</h4>
<p>can we add a <code>allow(clippy::rc-buffer)</code> for the next 6 weeks.</p>



<a name="217291367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217291367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217291367">(Nov 19 2020 at 16:10)</a>:</h4>
<p>Btw, Jacob's email is different between commits and Cargo.toml</p>



<a name="217291620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217291620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217291620">(Nov 19 2020 at 16:11)</a>:</h4>
<p>Saying just in case you want to use the same one and that's a mistake</p>



<a name="217291729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217291729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217291729">(Nov 19 2020 at 16:11)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120179">Eh2406</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217291265">said</a>:</p>
<blockquote>
<p>can we add a <code>allow(clippy::rc-buffer)</code> for the next 6 weeks.</p>
</blockquote>
<p>Ok, I'll add it.</p>



<a name="217291976"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217291976" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217291976">(Nov 19 2020 at 16:13)</a>:</h4>
<p>I have just given up on trying to be consistent on which email address and name I use, it all goes the same place.</p>



<a name="217293822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217293822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217293822">(Nov 19 2020 at 16:25)</a>:</h4>
<p>The history becomes linear (we are losing the merge commit) in the release branch after my manipulations. Is it fine?</p>



<a name="217293883"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217293883" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217293883">(Nov 19 2020 at 16:26)</a>:</h4>
<p>gimme 1 min, I'll fix it</p>



<a name="217293961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217293961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217293961">(Nov 19 2020 at 16:26)</a>:</h4>
<p>is it up?</p>



<a name="217294065"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217294065" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217294065">(Nov 19 2020 at 16:27)</a>:</h4>
<p>What I've done is<br>
1) amended the last commit in dev, pushed to origin/dev<br>
2) origin/release is the old one, not amended<br>
3) trying to replace "prepare 0.2" locally, lose merge commit</p>



<a name="217294251"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217294251" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217294251">(Nov 19 2020 at 16:28)</a>:</h4>
<p>what you can do is</p>
<ol>
<li>amend dev</li>
<li>reset hard release on tag v0.1.0</li>
<li>merge dev into release</li>
</ol>



<a name="217294514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217294514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217294514">(Nov 19 2020 at 16:29)</a>:</h4>
<p>I thought of doing that, why didn't I? Something stopped me. Hm. Was it that we lose merge commit info (<a href="https://github.com/rust-lang/rust/issues/67">#67</a> tag)? I guess it can be edited in as well.<br>
Let me try.</p>



<a name="217294804"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217294804" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217294804">(Nov 19 2020 at 16:31)</a>:</h4>
<p>Oh I remembered, I've done that and looked at the history <span aria-label="grinning" class="emoji emoji-1f600" role="img" title="grinning">:grinning:</span> I guess it's the same on origin/release. But it looks weird</p>



<a name="217294919"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217294919" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217294919">(Nov 19 2020 at 16:32)</a>:</h4>
<p>can't say from the distance ^^</p>



<a name="217295519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217295519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217295519">(Nov 19 2020 at 16:35)</a>:</h4>
<p>it's ok if 67 is not there anymore as long as there is a new merge commit and you mention 67 in the commit it will be linked into the PR</p>



<a name="217295659"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217295659" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217295659">(Nov 19 2020 at 16:36)</a>:</h4>
<p><a href="/user_uploads/4715/Rk0zQUyufRK8qf-7T1AqTFqz/Screenshot_20201119_193446.png">Screenshot_20201119_193446.png</a> <a href="/user_uploads/4715/0D3ivEWSGpYhkM1-4asMys_1/Screenshot_20201119_193438.png">Screenshot_20201119_193438.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/Rk0zQUyufRK8qf-7T1AqTFqz/Screenshot_20201119_193446.png" title="Screenshot_20201119_193446.png"><img src="/user_uploads/4715/Rk0zQUyufRK8qf-7T1AqTFqz/Screenshot_20201119_193446.png"></a></div><div class="message_inline_image"><a href="/user_uploads/4715/0D3ivEWSGpYhkM1-4asMys_1/Screenshot_20201119_193438.png" title="Screenshot_20201119_193438.png"><img src="/user_uploads/4715/0D3ivEWSGpYhkM1-4asMys_1/Screenshot_20201119_193438.png"></a></div>



<a name="217295744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217295744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217295744">(Nov 19 2020 at 16:37)</a>:</h4>
<p>Sorry I really can't read your graphs, felt confusing last time already ahah</p>



<a name="217295777"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217295777" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217295777">(Nov 19 2020 at 16:37)</a>:</h4>
<p>That's what I meant. There are those non-linear arrows))</p>



<a name="217295809"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217295809" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217295809">(Nov 19 2020 at 16:37)</a>:</h4>
<p>If you want I can just do it, will be quick</p>



<a name="217295900"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217295900" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217295900">(Nov 19 2020 at 16:38)</a>:</h4>
<p>What changes did you do? in addition to the ones of Jacob?</p>



<a name="217295923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217295923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217295923">(Nov 19 2020 at 16:38)</a>:</h4>
<p>Nothing, that's origin/release</p>



<a name="217295988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217295988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217295988">(Nov 19 2020 at 16:38)</a>:</h4>
<p>Yes that look correct. it is just a display thing.</p>



<a name="217296025"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217296025" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217296025">(Nov 19 2020 at 16:39)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217294251">said</a>:</p>
<blockquote>
<p>what you can do is</p>
<ol>
<li>amend dev</li>
<li>reset hard release on tag v0.1.0</li>
<li>merge dev into release</li>
</ol>
</blockquote>
<p>Give me a moment, I'll do that. I was just taking the time to screenshot the graphs</p>



<a name="217296784"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217296784" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217296784">(Nov 19 2020 at 16:44)</a>:</h4>
<p>Well, I can't rename the merge commit and the graph shows a bit differently. <span class="user-mention" data-user-id="348419">@Matthieu Pizenberg</span> you can try</p>



<a name="217296845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217296845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217296845">(Nov 19 2020 at 16:44)</a>:</h4>
<p><a href="/user_uploads/4715/5U2NhYS3EBzy5my-_CRwv_5V/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/5U2NhYS3EBzy5my-_CRwv_5V/image.png" title="image.png"><img src="/user_uploads/4715/5U2NhYS3EBzy5my-_CRwv_5V/image.png"></a></div>



<a name="217296860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217296860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217296860">(Nov 19 2020 at 16:45)</a>:</h4>
<p>where should I add the allow thingy for clippy?</p>



<a name="217296874"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217296874" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217296874">(Nov 19 2020 at 16:45)</a>:</h4>
<p>in th ecode I mean</p>



<a name="217296895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217296895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217296895">(Nov 19 2020 at 16:45)</a>:</h4>
<p>I've added that, it's in origin/dev</p>



<a name="217296914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217296914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217296914">(Nov 19 2020 at 16:45)</a>:</h4>
<p><a href="http://lib.rs">lib.rs</a> file</p>



<a name="217297034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217297034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217297034">(Nov 19 2020 at 16:46)</a>:</h4>
<p>alright 1 min</p>



<a name="217297105"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217297105" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217297105">(Nov 19 2020 at 16:47)</a>:</h4>
<p>Actually I found a way to not lose a merge commit during a rebase, let me try that</p>



<a name="217298178"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298178" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298178">(Nov 19 2020 at 16:54)</a>:</h4>
<p>When you have something just push I'll check the network graph on <a href="https://github.com/pubgrub-rs/pubgrub/network">https://github.com/pubgrub-rs/pubgrub/network</a></p>



<a name="217298313"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298313" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298313">(Nov 19 2020 at 16:55)</a>:</h4>
<p>I found the option <code>--rebase-merges</code> still looking into how to properly do that</p>



<a name="217298338"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298338" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298338">(Nov 19 2020 at 16:55)</a>:</h4>
<p>It's ok Alex</p>



<a name="217298347"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298347" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298347">(Nov 19 2020 at 16:55)</a>:</h4>
<p>Why didn't we just do the "fix" commit))</p>



<a name="217298433"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298433" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298433">(Nov 19 2020 at 16:56)</a>:</h4>
<p>Is it ok if I push now?</p>



<a name="217298476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298476">(Nov 19 2020 at 16:56)</a>:</h4>
<p>release branch you mean?</p>



<a name="217298488"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298488" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298488">(Nov 19 2020 at 16:56)</a>:</h4>
<p>yes</p>



<a name="217298489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298489">(Nov 19 2020 at 16:56)</a>:</h4>
<p>Sure, if you fixed it why not</p>



<a name="217298670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298670">(Nov 19 2020 at 16:58)</a>:</h4>
<p>ok should be updated: <a href="https://github.com/pubgrub-rs/pubgrub/network">https://github.com/pubgrub-rs/pubgrub/network</a></p>



<a name="217298777"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298777" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298777">(Nov 19 2020 at 16:58)</a>:</h4>
<p><span class="user-mention silent" data-user-id="340766">Alex Tokarev</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217296845">said</a>:</p>
<blockquote>
<p><a href="/user_uploads/4715/5U2NhYS3EBzy5my-_CRwv_5V/image.png">image.png</a></p>
</blockquote>
<p>The same I've got after my manipulations</p>



<a name="217298780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298780">(Nov 19 2020 at 16:58)</a>:</h4>
<p>commit is different but mentionned in PR: <a href="https://github.com/pubgrub-rs/pubgrub/pull/67">https://github.com/pubgrub-rs/pubgrub/pull/67</a></p>



<a name="217298882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298882">(Nov 19 2020 at 16:59)</a>:</h4>
<p>I guess it's whatever</p>



<a name="217298947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217298947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217298947">(Nov 19 2020 at 16:59)</a>:</h4>
<p>My fault I'm using "weird graph tooling" <span aria-label="stuck out tongue" class="emoji emoji-1f61b" role="img" title="stuck out tongue">:stuck_out_tongue:</span></p>



<a name="217299016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299016">(Nov 19 2020 at 17:00)</a>:</h4>
<p>It's Intellij Idea's git integration, for the reference</p>



<a name="217299115"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299115" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299115">(Nov 19 2020 at 17:00)</a>:</h4>
<p>witch is amazing (I can't do git without it), but sometimes a little confusing.</p>



<a name="217299174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299174">(Nov 19 2020 at 17:01)</a>:</h4>
<p><span class="user-mention" data-user-id="120179">@Eh2406</span> I think we are all set, could you retry publishing after fetching and reset hard</p>



<a name="217299189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299189">(Nov 19 2020 at 17:01)</a>:</h4>
<p>I live by terminal and tig ^^</p>



<a name="217299329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299329">(Nov 19 2020 at 17:02)</a>:</h4>
<p>What's tig?</p>



<a name="217299370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299370">(Nov 19 2020 at 17:02)</a>:</h4>
<p>Yes, just give me 5, I think I have one-per-mager working in my crates.io-&gt;benchmark</p>



<a name="217299496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299496">(Nov 19 2020 at 17:03)</a>:</h4>
<p>Tig is a tool to visualize the graph and commits in the terminal</p>



<a name="217299514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299514">(Nov 19 2020 at 17:03)</a>:</h4>
<p>There you go <span aria-label="high five" class="emoji emoji-1f590" role="img" title="high five">:high_five:</span></p>



<a name="217299636"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299636" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299636">(Nov 19 2020 at 17:04)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217299496">said</a>:</p>
<blockquote>
<p>Tig is a tool to visualize the graph and commits in the terminal</p>
</blockquote>
<p>Can you do the screenshot of before/after? Did it change for you?</p>



<a name="217299921"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217299921" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217299921">(Nov 19 2020 at 17:06)</a>:</h4>
<p><a href="/user_uploads/4715/b118I-VcancgntFh3r20qY-6/image.png">image.png</a> </p>
<div class="message_inline_image"><a href="/user_uploads/4715/b118I-VcancgntFh3r20qY-6/image.png" title="image.png"><img src="/user_uploads/4715/b118I-VcancgntFh3r20qY-6/image.png"></a></div><p>this is what I see with it</p>



<a name="217300211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217300211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217300211">(Nov 19 2020 at 17:08)</a>:</h4>
<p>don't have the before anymore sorry</p>



<a name="217300332"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217300332" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217300332">(Nov 19 2020 at 17:09)</a>:</h4>
<p>Got it from the package manager, it shows the same for before/after</p>



<a name="217300447"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217300447" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217300447">(Nov 19 2020 at 17:10)</a>:</h4>
<p>I usually do backup branches to more easily undo rebases, so I had it. Otherwise you have to spend more time with reflog.</p>



<a name="217300609"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217300609" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217300609">(Nov 19 2020 at 17:11)</a>:</h4>
<p>Nice terminal setup btw, I like how you did path and branch as arrows</p>



<a name="217300640"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217300640" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217300640">(Nov 19 2020 at 17:11)</a>:</h4>
<p>Is it a shell feature or do you use something like starship?</p>



<a name="217301005"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301005" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301005">(Nov 19 2020 at 17:14)</a>:</h4>
<p><a href="https://github.com/mpizenberg/dotfiles/tree/master/fish/.config/fish">https://github.com/mpizenberg/dotfiles/tree/master/fish/.config/fish</a></p>



<a name="217301012"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301012" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301012">(Nov 19 2020 at 17:14)</a>:</h4>
<p>using fish shell</p>



<a name="217301217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301217">(Nov 19 2020 at 17:15)</a>:</h4>
<p>killer feature is autocompletion capability and sane default setup, otherwise, pretty similar to zsh except it's not posix, which sometimes brings issues</p>



<a name="217301249"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301249" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301249">(Nov 19 2020 at 17:15)</a>:</h4>
<p>Ok I am back. I have my full version of one-per-mager compiling, I will work on seeing if it is correct some other time.</p>



<a name="217301331"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301331" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301331">(Nov 19 2020 at 17:16)</a>:</h4>
<p>Ah. I tried it out but it doesn't have history manipulation shortcuts that I like.<br>
E.g. <code>foobar</code> -&gt; no permissions<br>
<code>sudo !!</code> to repeat the last command with <code>sudo</code>.<br>
Or <code>!$</code> for "use the last argument from the previous command"</p>



<a name="217301515"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301515" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301515">(Nov 19 2020 at 17:17)</a>:</h4>
<p>I contributed to Ion shell by RedoxOS and used that for some time, got too annoyed with them using <code>@</code> for the scripting, so you can't copy-paste lines containing emails and such in the terminal.</p>



<a name="217301619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301619">(Nov 19 2020 at 17:18)</a>:</h4>
<p>Also it's not under very active development, sad.</p>



<a name="217301729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301729">(Nov 19 2020 at 17:18)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120179">Eh2406</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217301249">said</a>:</p>
<blockquote>
<p>Ok I am back. I have my full version of one-per-mager compiling, I will work on seeing if it is correct some other time.</p>
</blockquote>
<p>Who wants to do boring releases when you can do cool stuff <span aria-label="dark sunglasses" class="emoji emoji-1f576" role="img" title="dark sunglasses">:dark_sunglasses:</span></p>



<a name="217301746"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301746" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301746">(Nov 19 2020 at 17:19)</a>:</h4>
<p>I haven't felt like testing new shells recently, might try again in few years</p>



<a name="217301827"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217301827" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217301827">(Nov 19 2020 at 17:19)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217301746">said</a>:</p>
<blockquote>
<p>I haven't felt like testing new shells recently, might try again in few years</p>
</blockquote>
<p>I'm keeping an eye on <code>nushell</code>, might be ready for a prime time by then</p>



<a name="217302046"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302046" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302046">(Nov 19 2020 at 17:21)</a>:</h4>
<p>Killer feature is dropping of "everything is text" of traditional shells and keeping type information between pipes. Kinda like a powershell (I guess this was an inspiration) but with a sane syntax.</p>



<a name="217302189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302189">(Nov 19 2020 at 17:22)</a>:</h4>
<p>yeah might want to try that one at some point</p>



<a name="217302197"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302197" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302197">(Nov 19 2020 at 17:22)</a>:</h4>
<p>So your commands present you with structured data as table in their output, which you can use queries for.</p>



<a name="217302203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302203">(Nov 19 2020 at 17:22)</a>:</h4>
<p><code>cargo publish --dry-run</code> worked. am I good to go?</p>



<a name="217302356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302356">(Nov 19 2020 at 17:23)</a>:</h4>
<p>I need to verify my email address, brb</p>



<a name="217302398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302398">(Nov 19 2020 at 17:23)</a>:</h4>
<p>Btw, I remember <code>fish</code> author starting a new shell in Rust... What was its name...</p>



<a name="217302529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302529">(Nov 19 2020 at 17:24)</a>:</h4>
<p>don't know</p>



<a name="217302690"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302690" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302690">(Nov 19 2020 at 17:25)</a>:</h4>
<p><a href="https://www.reddit.com/r/rust/comments/ftb7fc/new_project_crush_a_command_line_shell/">https://www.reddit.com/r/rust/comments/ftb7fc/new_project_crush_a_command_line_shell/</a></p>



<a name="217302691"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302691" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302691">(Nov 19 2020 at 17:25)</a>:</h4>
<p><a href="/user_uploads/4715/CGlqftUEFO_isf6YAFnMBeKo/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/CGlqftUEFO_isf6YAFnMBeKo/image.png" title="image.png"><img src="/user_uploads/4715/CGlqftUEFO_isf6YAFnMBeKo/image.png"></a></div>



<a name="217302828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302828">(Nov 19 2020 at 17:26)</a>:</h4>
<p>Quick where are all publish buttons?!</p>



<a name="217302925"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302925" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302925">(Nov 19 2020 at 17:27)</a>:</h4>
<p>I'll verify that my elm dependency provider works with it now that it's too late #timing</p>



<a name="217302926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217302926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217302926">(Nov 19 2020 at 17:27)</a>:</h4>
<p>I don't understand you question?</p>



<a name="217303111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217303111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217303111">(Nov 19 2020 at 17:28)</a>:</h4>
<p>Still to do:</p>
<ul>
<li>[ ] github releases / tag</li>
<li>[ ] /r/rust announcement</li>
</ul>



<a name="217303182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217303182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217303182">(Nov 19 2020 at 17:29)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120179">Eh2406</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217302926">said</a>:</p>
<blockquote>
<p>I don't understand you question?</p>
</blockquote>
<p>Ah, that a reference to this and my subsequent comment <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217207411">https://rust-lang.zulipchat.com/#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217207411</a></p>



<a name="217303261"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217303261" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217303261">(Nov 19 2020 at 17:30)</a>:</h4>
<p>Also Elm post I guess</p>



<a name="217303478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217303478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217303478">(Nov 19 2020 at 17:31)</a>:</h4>
<p>Alright it's working :)</p>



<a name="217303500"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217303500" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217303500">(Nov 19 2020 at 17:31)</a>:</h4>
<p>doing the announcements now :)</p>



<a name="217304444"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217304444" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217304444">(Nov 19 2020 at 17:38)</a>:</h4>
<p>First one on the discourse <a href="https://discourse.elm-lang.org/t/solving-dependencies-of-11079-elm-packages-in-less-than-1s/6541">https://discourse.elm-lang.org/t/solving-dependencies-of-11079-elm-packages-in-less-than-1s/6541</a></p>



<a name="217304496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217304496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217304496">(Nov 19 2020 at 17:39)</a>:</h4>
<p>had to modify all the end of lines and @ which was interpretted as people :(</p>



<a name="217304933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217304933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217304933">(Nov 19 2020 at 17:42)</a>:</h4>
<p>And on reddit: <a href="https://www.reddit.com/r/rust/comments/jx794b/announcing_pubgrub_v02_a_flexible_version_solver/">https://www.reddit.com/r/rust/comments/jx794b/announcing_pubgrub_v02_a_flexible_version_solver/</a></p>



<a name="217305028"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305028" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305028">(Nov 19 2020 at 17:43)</a>:</h4>
<p>git tag -s v0.1.0<br>
fatal: tag 'v0.1.0' already exists</p>



<a name="217305054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305054">(Nov 19 2020 at 17:43)</a>:</h4>
<p>Maybe I can't sign existing tag</p>



<a name="217305076"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305076" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305076">(Nov 19 2020 at 17:43)</a>:</h4>
<p>probably not</p>



<a name="217305124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305124">(Nov 19 2020 at 17:43)</a>:</h4>
<p>you can sign v0.2.0 though</p>



<a name="217305231"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305231" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305231">(Nov 19 2020 at 17:44)</a>:</h4>
<p>Should I recreate v0.1.0?</p>



<a name="217305273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305273">(Nov 19 2020 at 17:44)</a>:</h4>
<p>as you wish</p>



<a name="217305337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305337">(Nov 19 2020 at 17:45)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217304933">said</a>:</p>
<blockquote>
<p>And on reddit: <a href="https://www.reddit.com/r/rust/comments/jx794b/announcing_pubgrub_v02_a_flexible_version_solver/">https://www.reddit.com/r/rust/comments/jx794b/announcing_pubgrub_v02_a_flexible_version_solver/</a></p>
</blockquote>
<p>Upvoted</p>



<a name="217305471"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305471" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305471">(Nov 19 2020 at 17:46)</a>:</h4>
<p>It has zip with content on Github though</p>



<a name="217305510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305510">(Nov 19 2020 at 17:46)</a>:</h4>
<p>Maybe having only v0.2.0 signed is fine</p>



<a name="217305574"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305574" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305574">(Nov 19 2020 at 17:47)</a>:</h4>
<p><span class="user-mention silent" data-user-id="340766">Alex Tokarev</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217305471">said</a>:</p>
<blockquote>
<p>It has zip with content on Github though</p>
</blockquote>
<p>How did you add that btw? Did Github generate the artifacts?</p>



<a name="217305649"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305649" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305649">(Nov 19 2020 at 17:47)</a>:</h4>
<p>I'm not sure I understand your question</p>



<a name="217305756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305756">(Nov 19 2020 at 17:48)</a>:</h4>
<p><a href="https://github.com/pubgrub-rs/pubgrub/tags">https://github.com/pubgrub-rs/pubgrub/tags</a></p>



<a name="217305762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305762">(Nov 19 2020 at 17:48)</a>:</h4>
<p>that's automatic for tags I think when you upload them</p>



<a name="217305769"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305769" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305769">(Nov 19 2020 at 17:48)</a>:</h4>
<p>There are .zip and .tar.gz archives</p>



<a name="217305777"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305777" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305777">(Nov 19 2020 at 17:48)</a>:</h4>
<p>Ah, okay</p>



<a name="217305865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305865">(Nov 19 2020 at 17:49)</a>:</h4>
<p>I think it is automatic when you add a release.</p>



<a name="217305869"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217305869" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217305869">(Nov 19 2020 at 17:49)</a>:</h4>
<p>Then you can transform them into GitHub "release" where you can add a bunch of other things and custom artifacts</p>



<a name="217310098"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217310098" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217310098">(Nov 19 2020 at 18:22)</a>:</h4>
<p>I signed a new testing branch with a new tag "signedtag", you can see it in the link above</p>



<a name="217310124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217310124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217310124">(Nov 19 2020 at 18:22)</a>:</h4>
<p>can you run <code>git tag -v signedtag</code> please?</p>



<a name="217310571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217310571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217310571">(Nov 19 2020 at 18:26)</a>:</h4>
<p>Tried from another machine:</p>
<div class="codehilite"><pre><span></span><code>[aleksator@X1E pubgrub-rs]$ git tag -v signedtag
object a8c47a08787b92ba5932cb8e2a789bbe99059b05
type commit
tag signedtag
tagger Alex Tokarev &lt;aleksator@gmail.com&gt; 1605809921 +0300

testing signing
gpg: Signature made Thu 19 Nov 2020 21:18:48 MSK
gpg:                using DSA key CEE3D61DA47DF389A03DFB7C6ECAF92E6B5EE3D9
gpg:                issuer &quot;aleksator@gmail.com&quot;
gpg: Can&#39;t check signature: No public key
</code></pre></div>



<a name="217310643"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217310643" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217310643">(Nov 19 2020 at 18:26)</a>:</h4>
<p>Basically, "Who is that guy?". I wonder if I can get a public key from git itself.</p>



<a name="217311165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217311165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217311165">(Nov 19 2020 at 18:31)</a>:</h4>
<p>Ah, I probably need to upload it to Github!</p>



<a name="217313088"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217313088" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217313088">(Nov 19 2020 at 18:47)</a>:</h4>
<p>sorry in a meeting.</p>



<a name="217313242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217313242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217313242">(Nov 19 2020 at 18:48)</a>:</h4>
<p>will check later tonight</p>



<a name="217315210"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217315210" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217315210">(Nov 19 2020 at 19:03)</a>:</h4>
<p>Looks like you need to download my public key from <a href="https://github.com/aleksator.gpg">https://github.com/aleksator.gpg</a> and import into gpg database for that command to verify the signature...</p>



<a name="217315712"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217315712" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217315712">(Nov 19 2020 at 19:08)</a>:</h4>
<p>Well at least there's a message <code>This tag was signed with a verified signature.</code> on Github</p>



<a name="217315883"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217315883" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217315883">(Nov 19 2020 at 19:09)</a>:</h4>
<p>Also tag doesn't change when you change commits, it's immutable. So you can't invalidate the tag after signing, it will just diverge from branch you change the branch.</p>



<a name="217316018"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217316018" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217316018">(Nov 19 2020 at 19:10)</a>:</h4>
<p><a href="/user_uploads/4715/mhB5KpLqc-dCKFk_H1n3nNS0/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/mhB5KpLqc-dCKFk_H1n3nNS0/image.png" title="image.png"><img src="/user_uploads/4715/mhB5KpLqc-dCKFk_H1n3nNS0/image.png"></a></div>



<a name="217316078"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217316078" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217316078">(Nov 19 2020 at 19:11)</a>:</h4>
<p>Yes, if you want to change a tag, you have to delete it and make a new one, then force push.</p>



<a name="217316812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217316812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217316812">(Nov 19 2020 at 19:16)</a>:</h4>
<p>Alright, I've created v0.2.0 tag! I'll delete 'signedtag' when you no longer need to test how it all works.</p>



<a name="217316856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217316856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217316856">(Nov 19 2020 at 19:16)</a>:</h4>
<p><a href="https://github.com/pubgrub-rs/pubgrub/releases/tag/v0.2.0">https://github.com/pubgrub-rs/pubgrub/releases/tag/v0.2.0</a></p>



<a name="217320521"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217320521" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217320521">(Nov 19 2020 at 19:43)</a>:</h4>
<p>I emailed Natalie.</p>



<a name="217335864"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217335864" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217335864">(Nov 19 2020 at 21:54)</a>:</h4>
<blockquote>
<p>Alright, I've created v0.2.0 tag! I'll delete 'signedtag' when you no longer need to test how it all works.</p>
</blockquote>
<p>what should I try? what did you want to check?</p>



<a name="217336230"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217336230" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217336230">(Nov 19 2020 at 21:57)</a>:</h4>
<p>I've already tested our previous assumptions myself: created a signed tag, tried modifying signed commits and seeing if it changes the tag (it does not). I've also tried manual verification of tag on my PC, which requires importing my public key into PGP keystore... Ain't nobody got time for that. We got a sweet "verified" label next to the Github release though <span aria-label="grinning" class="emoji emoji-1f600" role="img" title="grinning">:grinning:</span></p>
<p>I was saying I'll keep the tag in case you wanted to try some of that yourself.</p>



<a name="217336336"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217336336" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217336336">(Nov 19 2020 at 21:58)</a>:</h4>
<p>If you don't, we can delete "signedtag" from git</p>



<a name="217336443"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217336443" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217336443">(Nov 19 2020 at 21:59)</a>:</h4>
<p>damn I responded on the wrong thread</p>



<a name="217336519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217336519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217336519">(Nov 19 2020 at 21:59)</a>:</h4>
<p>You can edit what thread a comment is in.</p>



<a name="217336613"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217336613" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217336613">(Nov 19 2020 at 22:00)</a>:</h4>
<p>You can make fun of that label in any thread you wish <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="217336857"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217336857" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217336857">(Nov 19 2020 at 22:02)</a>:</h4>
<p>Ok we can delete it then</p>



<a name="217336889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217336889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217336889">(Nov 19 2020 at 22:03)</a>:</h4>
<p>(the tag, not the thread XD)</p>



<a name="217337212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217337212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217337212">(Nov 19 2020 at 22:05)</a>:</h4>
<p>I guess you can also test everything with v0.2.0 tag locally if you ever want to. Deleting then</p>



<a name="217337872"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217337872" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217337872">(Nov 19 2020 at 22:10)</a>:</h4>
<p><a href="https://github.com/pubgrub-rs/pubgrub/blame/release/CHANGELOG.md#L137">https://github.com/pubgrub-rs/pubgrub/blame/release/CHANGELOG.md#L137</a></p>
<p>f*** I had to mess up with something. I guess nobody will click on this anyway XD</p>



<a name="217338067"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217338067" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217338067">(Nov 19 2020 at 22:12)</a>:</h4>
<blockquote>
<p>I guess nobody will click on this anyway XD</p>
</blockquote>
<p>Sad truth.</p>



<a name="217338180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217338180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217338180">(Nov 19 2020 at 22:13)</a>:</h4>
<p>Well, at least we got 3 new stars <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="217338210"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217338210" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217338210">(Nov 19 2020 at 22:13)</a>:</h4>
<p><span class="user-mention silent" data-user-id="348419">Matthieu Pizenberg</span> <a href="#narrow/stream/260232-t-cargo.2FPubGrub/topic/Wrapping.20up.20v0.2E2/near/217286631">said</a>:</p>
<blockquote>
<blockquote>
<p>It would not be a release unless we bungled up something. :-)</p>
</blockquote>
<p>It was foretold ...</p>
</blockquote>
<p>so true</p>



<a name="217338529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217338529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217338529">(Nov 19 2020 at 22:16)</a>:</h4>
<p>By the way the update on the "most recent version of all crates on <a href="http://crates.io">crates.io</a>" is that there are <strong>a lot</strong> of crates, and some of them definitely take a while to resolve. (and yes I am running in release.)</p>



<a name="217338647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217338647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217338647">(Nov 19 2020 at 22:17)</a>:</h4>
<p>I wonder by how much cargo beats us <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="217338830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217338830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217338830">(Nov 19 2020 at 22:19)</a>:</h4>
<blockquote>
<p>some of them definitely take a while to resolve</p>
</blockquote>
<p>I thought of comparing our resolution time against that of cargo</p>



<a name="217339022"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217339022" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217339022">(Nov 19 2020 at 22:21)</a>:</h4>
<p>Sorry, yes, I understood. I wonder as well. I thought that reaction would express shared curiosity.</p>



<a name="217339055"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217339055" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217339055">(Nov 19 2020 at 22:21)</a>:</h4>
<p>Ah, gotcha!</p>



<a name="217339914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217339914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217339914">(Nov 19 2020 at 22:31)</a>:</h4>
<blockquote>
<p>By the way the update on the "most recent version of all crates on <a href="http://crates.io">crates.io</a>" is that there are a lot of crates, and some of them definitely take a while to resolve. (and yes I am running in release.)</p>
</blockquote>
<p>Do you have an estimate of the mean time per package for what you've run already?</p>



<a name="217340845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217340845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217340845">(Nov 19 2020 at 22:40)</a>:</h4>
<p>No, but that would be a great statistic! So far I have not been keeping timings as caching means that some take a lot of time reading the index and others take time resolving. My plan was to make one massive ron file and do stats on that. But with how long it takes that may not be a good plan.</p>



<a name="217341437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217341437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217341437">(Nov 19 2020 at 22:47)</a>:</h4>
<p>from: Natalie Weizenbaum to me</p>
<blockquote>
<p>That's awesome! What a great guide!</p>
</blockquote>
<p>Just passing along the feedback I got.</p>



<a name="217341617"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217341617" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217341617">(Nov 19 2020 at 22:49)</a>:</h4>
<p>Ah, sitting there refreshing reddit, discourse and this chat has paid off!<br>
Alright, now I feel validated and can finally go to bed! <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="217343202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217343202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217343202">(Nov 19 2020 at 23:07)</a>:</h4>
<blockquote>
<p>I have not been keeping timings as caching means that some take a lot of time reading the index and others take time resolving</p>
</blockquote>
<p><span class="user-mention" data-user-id="120179">@Eh2406</span> took me a whole afternoon to download every package <code>elm.json</code> config file before making the ron file</p>



<a name="217343293"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217343293" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217343293">(Nov 19 2020 at 23:08)</a>:</h4>
<p>but didn't start solving anything before getting that ron file, which granted was quite small for elm</p>



<a name="217343494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217343494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217343494">(Nov 19 2020 at 23:10)</a>:</h4>
<p><a href="https://crates.io/">https://crates.io/</a> : 49,731 Crates in stock</p>



<a name="217343495"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217343495" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217343495">(Nov 19 2020 at 23:10)</a>:</h4>
<p>How is the API of <a href="http://crates.io">crates.io</a> to retrieve package information like cargo.toml or a list of all package versions?</p>



<a name="217343630"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217343630" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217343630">(Nov 19 2020 at 23:12)</a>:</h4>
<p><a href="https://github.com/rust-lang/crates.io-index">https://github.com/rust-lang/crates.io-index</a> just download it.<br>
There is eaven a crate for parsing it <a href="https://crates.io/crates/crates-index">https://crates.io/crates/crates-index</a></p>



<a name="217343705"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/Wrapping%20up%20v0.2/near/217343705" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/Wrapping.20up.20v0.2E2.html#217343705">(Nov 19 2020 at 23:13)</a>:</h4>
<p><a href="https://github.com/rust-lang/crates.io-index/tree/master/pu/bg">https://github.com/rust-lang/crates.io-index/tree/master/pu/bg</a> :)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>